Closed
Bug 397614
Opened 17 years ago
Closed 17 years ago
BrowserGlue's QI doesn't need to declare nsISupports
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 3 beta1
People
(Reporter: rflint, Assigned: rflint)
Details
Attachments
(1 file)
1.29 KB,
patch
|
Gavin
:
review+
mconnor
:
approval1.9+
|
Details | Diff | Splinter Review |
PCOMUtils assumes components using generateQI implement nsISupports, so there's no need for the component itself to say it does.
Attachment #282369 -
Flags: review?(gavin.sharp)
Comment 1•17 years ago
|
||
Comment on attachment 282369 [details] [diff] [review] Patch Fix the other one too (placesBaseTransaction in nsPlacesTransactionsService.js)? r=me
Attachment #282369 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 2•17 years ago
|
||
Comment on attachment 282369 [details] [diff] [review] Patch (In reply to comment #1) > Fix the other one too (placesBaseTransaction in > nsPlacesTransactionsService.js)? > Sure, I'll do it on checkin.
Attachment #282369 -
Flags: approval1.9?
Updated•17 years ago
|
Attachment #282369 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 3•17 years ago
|
||
mozilla/browser/components/nsBrowserGlue.js 1.36 mozilla/browser/components/places/src/nsPlacesTransactionsService.js 1.5
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M9
You need to log in
before you can comment on or make changes to this bug.
Description
•