Closed Bug 397759 Opened 17 years ago Closed 17 years ago

make TinderboxMailNotifier be able to report many slave builders as individual columns

Categories

(Release Engineering :: General, defect, P2)

Product:
Release Engineering
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

Details

Attachments

(2 files, 3 obsolete files)

the correct file
597 bytes, text/plain
Details
same as before, fixed indentation
3.36 KB, patch
Details | Diff | Splinter Review 
This feature request came out of bug#397755. Basically, it's confusing to have many slaves reporting to one Tinderbox tree. There a workaround for it, but it's not something I'd want put into the Buildbot tree. It shouldn't be hard to make it robust. I've attached it here.

My suggestion is to have a format string passed in. %b could be builder name, %s could be slave name, etc. There's probably other useful things.
Attached file tinderboxpoller (obsolete) — 

    
    

    
  

      
      
      
      

        Attached file
          
        the correct file
        — 
      

    


  

        Attachment #282543 -
        Attachment is obsolete: true

    
  
Assignee: nobody → bhearsum

    
  
Status: NEW → ASSIGNED

    
    

    
  
Axel and I talked about this on IRC a bit. This may be implementable using the 'WithProperties' rather than using a custom format. This implementation is probably preferred over my original suggestion.

    
  
Summary: make TinderboxMailNotifier be able to report many slave builders as individual trees → make TinderboxMailNotifier be able to report many slave builders as individual columns

    
  
Priority: -- → P3

    
  
Priority: P3 → P2

    
    

    
  


  
I've added a 'columnFormat' parameter to the class. It's described well in the docstring. Basically, you can give it a WithProperties instance and it will interpolate the variables as a ShellCommand does.

        Attachment #283552 -
        Flags: review?(l10n)

    
    

    
  
Comment on attachment 283552 [details] [diff] [review]
adds WithProperties support to TinderboxMailNotifier

r=me with changing the parameter name from columnFormat to columnName. WithProperties usually works for the actual value, so let's keep the naming consistent, as discussed on irc.

        Attachment #283552 -
        Flags: review?(l10n) → review+

    
    

    
  


  
Same patch as before, renaming 'columnFormat' to 'columnName'.

        Attachment #283552 -
        Attachment is obsolete: true

    
    

    
  


  
Carrying review in comment#5 over.

        Attachment #284465 -
        Attachment is obsolete: true

    
    

    
  
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
    

    
  
Mass move of Core:Testing bugs to mozilla.org:ReleaseEngineering. Filter on RelEngMassMove to ignore.
Component: Testing → Release Engineering
Product: Core → mozilla.org
QA Contact: testing → release
Version: unspecified → other
Product: mozilla.org → Release Engineering

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: