Closed
Bug 397759
Opened 18 years ago
Closed 18 years ago
make TinderboxMailNotifier be able to report many slave builders as individual columns
Categories
(Release Engineering :: General, defect, P2)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
Details
Attachments
(2 files, 3 obsolete files)
|
597 bytes,
text/plain
|
Details | |
|
3.36 KB,
patch
|
Details | Diff | Splinter Review |
This feature request came out of bug#397755. Basically, it's confusing to have many slaves reporting to one Tinderbox tree. There a workaround for it, but it's not something I'd want put into the Buildbot tree. It shouldn't be hard to make it robust. I've attached it here.
My suggestion is to have a format string passed in. %b could be builder name, %s could be slave name, etc. There's probably other useful things.
|
Assignee | |
Comment 1•18 years ago
|
||
|
|
Assignee | |
Comment 2•18 years ago
|
||
Attachment #282543 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•18 years ago
|
Assignee: nobody → bhearsum
|
|
Assignee | |
Updated•18 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•18 years ago
|
||
Axel and I talked about this on IRC a bit. This may be implementable using the 'WithProperties' rather than using a custom format. This implementation is probably preferred over my original suggestion.
|
|
Assignee | |
Updated•18 years ago
|
Summary: make TinderboxMailNotifier be able to report many slave builders as individual trees → make TinderboxMailNotifier be able to report many slave builders as individual columns
|
|
Assignee | |
Updated•18 years ago
|
Priority: -- → P3
|
|
Assignee | |
Updated•18 years ago
|
Priority: P3 → P2
|
|
Assignee | |
Comment 4•18 years ago
|
||
I've added a 'columnFormat' parameter to the class. It's described well in the docstring. Basically, you can give it a WithProperties instance and it will interpolate the variables as a ShellCommand does.
Attachment #283552 -
Flags: review?(l10n)
|
||
Comment 5•18 years ago
|
||
Comment on attachment 283552 [details] [diff] [review]
adds WithProperties support to TinderboxMailNotifier
r=me with changing the parameter name from columnFormat to columnName. WithProperties usually works for the actual value, so let's keep the naming consistent, as discussed on irc.
Attachment #283552 -
Flags: review?(l10n) → review+
|
|
Assignee | |
Comment 6•18 years ago
|
||
Same patch as before, renaming 'columnFormat' to 'columnName'.
Attachment #283552 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•18 years ago
|
||
Carrying review in comment#5 over.
Attachment #284465 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 8•18 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Comment 9•16 years ago
|
||
Mass move of Core:Testing bugs to mozilla.org:ReleaseEngineering. Filter on RelEngMassMove to ignore.
Component: Testing → Release Engineering
Product: Core → mozilla.org
QA Contact: testing → release
Version: unspecified → other
|
||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•