Closed Bug 397783 Opened 12 years ago Closed 12 years ago

Remove lots of redundant nsISupportsArray include/forward definitions from content

Categories

(Core :: Layout, defect, minor)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(2 files)

The fix (checked in)
7.71 KB, patch
jst
: review+
jst
: superreview+
damons
: approval1.9+
Details | Diff | Splinter Review
Two more instances (checked in)
1.15 KB, patch
jst
: review+
jst
: superreview+
mtschrep
: approval1.9+
Details | Diff | Splinter Review 
nsISupportsArray is obsolete and should go away, but in either case the includes and forward definitions in the patch I'm attaching are just redundant.

I've successfully compiled FF, SM and TB on Linux with this patch. Shouldn't affect anything other than compilation speed.
Attachment #282565 - Flags: superreview?(jst)
Attachment #282565 - Flags: review?(jst)
Comment on attachment 282565 [details] [diff] [review]
The fix (checked in)

Looks good, r+sr=jst
Attachment #282565 - Flags: superreview?(jst)
Attachment #282565 - Flags: superreview+
Attachment #282565 - Flags: review?(jst)
Attachment #282565 - Flags: review+
Comment on attachment 282565 [details] [diff] [review]
The fix (checked in)

Requesting approval for checkin for 1.9. Low risk as any problems will be brought up at compliation stage.
Attachment #282565 - Flags: approval1.9?
Comment on attachment 282565 [details] [diff] [review]
The fix (checked in)

a1.9=dbaron
Attachment #282565 - Flags: approval1.9? → approval1.9+
Comment on attachment 282565 [details] [diff] [review]
The fix (checked in)

I checked this in a few days ago. There's a couple of instances I missed, so I'll add them in a new patch.
Attachment #282565 - Attachment description: The fix → The fix (checked in)
Sorry for not finding these previously.
Attachment #284618 - Flags: superreview?(jst)
Attachment #284618 - Flags: review?(jst)
Comment on attachment 282565 [details] [diff] [review]
The fix (checked in)

Resetting all approval1.9+ flags on bugs that have not been checked in by Oct 22 11:59 PM PDT.  Please re-request approval if needed.
Attachment #282565 - Flags: approval1.9+
Comment on attachment 282565 [details] [diff] [review]
The fix (checked in)

Landed by standard8 on 2007-10-09 11:41.
Attachment #282565 - Flags: approval1.9?
Comment on attachment 282565 [details] [diff] [review]
The fix (checked in)

Reset approval flag to + as it was already checked in.
Attachment #282565 - Flags: approval1.9? → approval1.9+
Attachment #284618 - Flags: superreview?(jst)
Attachment #284618 - Flags: superreview+
Attachment #284618 - Flags: review?(jst)
Attachment #284618 - Flags: review+
Comment on attachment 284618 [details] [diff] [review]
Two more instances (checked in)

Requesting approval for 1.9. Very low risk - any problems (which there shouldn't be) will occur at compile time.
Attachment #284618 - Flags: approval1.9?
Attachment #284618 - Flags: approval1.9? → approval1.9+
Attachment #284618 - Attachment description: Two more instances → Two more instances (checked in)
Both patches checked in -> fixed.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.