Need to be able to support different kinds of HTTP auth

VERIFIED FIXED

Status

()

Core
Networking
P3
normal
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: shaver, Assigned: shaver)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Even if we don't provide Digest or NTLM auth any time soon, we should get the
hooks in as part of architectural completeness so that others can add them
later.  Seems pretty straight-forward, I'll see if I can find some time this
weekend to hack a little.

Comment 1

18 years ago
shaver: if you are referring to mechanisms to allow other kinds of auth 
implementations then that already exists in our current implementation. 
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → WORKSFORME
Well, I gotta say I'm right confused then, Gagan.

nsHTTPChannel::Authenticate shows:

1811-    // change this later to include other kinds of authentication. TODO 
1812:    if (NS_FAILED(rv = nsBasicAuth::Authenticate(
1813-                    mURI, 
1814-                    NS_STATIC_CAST(const char*, iChallenge), 

How would I plug in another kind of auth?

Comment 3

18 years ago
ouch. I thought I had fixed that! 
I will now... sorry about that. 
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
I've got pieces of it in my tree now (use of an "http-auth" category there,
rather than hard-coding the creation), so if you've got other pressing stuff
feel free to reassign.

Comment 5

18 years ago
excellent! take it away!
Assignee: gagan → shaver
Status: REOPENED → NEW
Why does shaver@netscape.com even work?
Assignee: shaver → shaver
Created attachment 8952 [details] [diff] [review]
Patch to use "http-auth" category and modularize nsBasicAuth
Hold the phone.  I need to:
- permit authentication that doesn't interact with the user, like kerberos, or
interacts in a way other than username/password (like NTLM, I think)
- make this more general, so that other protocols (IMAP, POP, whatever) can use
it for making their auth pluggable as well.

I'm working on that stuff now, stay tuned.
Status: NEW → ASSIGNED
Created attachment 8977 [details] [diff] [review]
More general form of the above, including enhanced interface.
Looking for review and approval, I am.
Done like dinner.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago18 years ago
Resolution: --- → FIXED

Comment 12

18 years ago
verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.