39781 - Need to be able to support different kinds of HTTP auth

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Even if we don't provide Digest or NTLM auth any time soon, we should get the
hooks in as part of architectural completeness so that others can add them
later.  Seems pretty straight-forward, I'll see if I can find some time this
weekend to hack a little.

Comment 1

[Gagan]

shaver: if you are referring to mechanisms to allow other kinds of auth 
implementations then that already exists in our current implementation. 

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Well, I gotta say I'm right confused then, Gagan.

nsHTTPChannel::Authenticate shows:

1811-    // change this later to include other kinds of authentication. TODO 
1812:    if (NS_FAILED(rv = nsBasicAuth::Authenticate(
1813-                    mURI, 
1814-                    NS_STATIC_CAST(const char*, iChallenge), 

How would I plug in another kind of auth?

Comment 3

[Gagan]

ouch. I thought I had fixed that! 
I will now... sorry about that. 

Comment 4

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

I've got pieces of it in my tree now (use of an "http-auth" category there,
rather than hard-coding the creation), so if you've got other pressing stuff
feel free to reassign.

Comment 5

[Gagan]

excellent! take it away!

Comment 6

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Why does [e-mail] even work?

Comment 7

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Attachment: Patch to use "http-auth" category and modularize nsBasicAuth

Comment 8

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Hold the phone.  I need to:
- permit authentication that doesn't interact with the user, like kerberos, or
interacts in a way other than username/password (like NTLM, I think)
- make this more general, so that other protocols (IMAP, POP, whatever) can use
it for making their auth pluggable as well.

I'm working on that stuff now, stay tuned.

Comment 9

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Attachment: More general form of the above, including enhanced interface.

Comment 10

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Looking for review and approval, I am.

Comment 11

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Done like dinner.

Comment 12

[Tom Everingham]

verified