Closed Bug 397819 Opened 17 years ago Closed 17 years ago

Microsummaries uses e4x Namespace objects when it shouldn't

Categories

(Firefox Graveyard :: Microsummaries, defect)

Product:
Firefox Graveyard
Component:
Microsummaries
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sayrer, Assigned: sayrer)

Details

Attachments

(1 file)

change to strings
1.39 KB, patch
myk
: review+
mconnor
: approval1.9+
Details | Diff | Splinter Review 
The two consts at the top of the file are passed to things like getElementsByTagNameNS, which take string args.
Component: DOM → Microsummaries
Product: Core → Firefox
QA Contact: general → microsummaries
Saw these in a cycle collection graph.
Assignee: nobody → sayrer
Status: NEW → ASSIGNED
Attachment #282611 - Flags: review?(myk)
Not sure how a JS object gets unknown refs:

n0x2eb744c0 -> n0x3673eac0
n0x2eb74540 [label="JS Object (Namespace)\n0x2eb74540\n1/2 refs found", fillcolor=black, fontcolor=white]
n0x2eb74540 -> n0x2eb7a010
n0x2eb74540 -> n0x2eb744e0
n0x2eb74540 -> n0x2eb6f540
n0x2eb74560 [label="JS Object (Namespace)\n0x2eb74560\n1/2 refs found", fillcolor=black, fontcolor=white]
n0x2eb74560 -> n0x2eb7a020
n0x2eb74560 -> n0x2eb744e0
n0x2eb74560 -> n0x2eb6f540
n0x2eb6f9e0 [label="JS Object (Function - MicrosummaryService)\n0x2eb6f9e0\n3/3 refs found", fillcolor=black, fontcolor=white]
n0x2eb6f9e0 -> n0x2eb6f560
n0x2eb6f9e0 -> n0x2eb6f540
n0x2eb6f9e0 -> n0x2eb745a0
Comment on attachment 282611 [details] [diff] [review]
change to strings

Good catch! r=myk
Attachment #282611 - Flags: review?(myk) → review+
Attachment #282611 - Flags: approval1.9?
Attachment #282611 - Flags: approval1.9? → approval1.9+
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: