Closed
Bug 397890
Opened 17 years ago
Closed 17 years ago
Reporter & safebrowsing overlay cleanup
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: rflint, Assigned: rflint)
Details
Attachments
(1 file)
|
3.74 KB,
patch
|
Gavin
:
review+
mconnor
:
approval1.9+
|
Details | Diff | Splinter Review |
Overlays don't (and shouldn't) need to include the global stylesheet. Reporter's overlay first did it and safebrowsing copied that verbatim - hence the removal of the inaccurate license to match it's neighbor: http://mxr.mozilla.org/mozilla/source/browser/components/safebrowsing/content/warning-overlay.xul.
Attachment #282681 -
Flags: review?(gavin.sharp)
|
Assignee | |
Comment 1•17 years ago
|
||
Doh, seems Robert did write that - assume that license block is still intact. :)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 282681 [details] [diff] [review] Patch r=me with the license header left alone.
Attachment #282681 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #282681 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Attachment #282681 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 3•17 years ago
|
||
mozilla/extensions/reporter/resources/content/reporter/reporterOverlay.xul 1.9 mozilla/browser/components/safebrowsing/content/report-phishing-overlay.xul 1.8
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•