397921 - Sisyphus - remove dependency on custom /usr/local/bin/bash

Status: RESOLVED FIXED

(Testing Graveyard :: Sisyphus, defect)

Description

[Bob Clary [:bc] (inactive)]

Sisyphus currently has at least one dependency on bash 3.x (pipefail in library.sh). Mac OS X ships with a version of bash 2 which does not support pipefail. The kludgey approach I used was to build custom bash 3.x on Mac OS X into /usr/local/bin/bash, symlink /bin/bash to /usr/local/bin/bash on Linux, Win and use a shebang of #!/usr/local/bin/bash in the shell scripts in Sisyphus.

pipefail was introduced some time ago to deal with failures in pipelines and may not be needed any more. 

Investigate whether pipefail and other bash 3.x only features can be removed so that all platforms can use the default /bin/bash shell. If bash 3 is required, investigate using mac ports to automatically install a current version of bash 3 on Mac OS X.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: patch (sans whitespace) for sisyphus to use /bin/bash

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: patch (with whitespace) for sisyphus to use /bin/bash

Comment 3

[Bob Clary [:bc] (inactive)]

Attachment: patch for js/tests/*.sh to use /bin/bash

Comment 4

[Bob Clary [:bc] (inactive)]

attachment 283550 [details] [diff] [review] checked into testing/sisyphus

Checking in bin/build.sh;
/cvsroot/mozilla/testing/sisyphus/bin/build.sh,v  <--  build.sh
new revision: 1.5; previous revision: 1.4
done
Checking in bin/builder.sh;
/cvsroot/mozilla/testing/sisyphus/bin/builder.sh,v  <--  builder.sh
new revision: 1.4; previous revision: 1.3
done
Checking in bin/check-spider.sh;
/cvsroot/mozilla/testing/sisyphus/bin/check-spider.sh,v  <--  check-spider.sh
new revision: 1.3; previous revision: 1.2
done
Checking in bin/checkout.sh;
/cvsroot/mozilla/testing/sisyphus/bin/checkout.sh,v  <--  checkout.sh
new revision: 1.3; previous revision: 1.2
done
Checking in bin/clean.sh;
/cvsroot/mozilla/testing/sisyphus/bin/clean.sh,v  <--  clean.sh
new revision: 1.3; previous revision: 1.2
done
Checking in bin/create-directory.sh;
/cvsroot/mozilla/testing/sisyphus/bin/create-directory.sh,v  <--  create-directory.sh
new revision: 1.3; previous revision: 1.2
done
Checking in bin/create-profile.sh;
/cvsroot/mozilla/testing/sisyphus/bin/create-profile.sh,v  <--  create-profile.sh
new revision: 1.3; previous revision: 1.2
done
Checking in bin/download.sh;
/cvsroot/mozilla/testing/sisyphus/bin/download.sh,v  <--  download.sh
new revision: 1.3; previous revision: 1.2
done
Checking in bin/edit-talkback.sh;
/cvsroot/mozilla/testing/sisyphus/bin/edit-talkback.sh,v  <--  edit-talkback.sh
new revision: 1.5; previous revision: 1.4
done
Checking in bin/install-build.sh;
/cvsroot/mozilla/testing/sisyphus/bin/install-build.sh,v  <--  install-build.sh
new revision: 1.5; previous revision: 1.4
done
Checking in bin/install-extensions.sh;
/cvsroot/mozilla/testing/sisyphus/bin/install-extensions.sh,v  <--  install-extensions.sh
new revision: 1.3; previous revision: 1.2
done
Checking in bin/install-plugins.sh;
/cvsroot/mozilla/testing/sisyphus/bin/install-plugins.sh,v  <--  install-plugins.sh
new revision: 1.3; previous revision: 1.2
done
Checking in bin/library.sh;
/cvsroot/mozilla/testing/sisyphus/bin/library.sh,v  <--  library.sh
new revision: 1.5; previous revision: 1.4
done
Checking in bin/sayvars.sh;
/cvsroot/mozilla/testing/sisyphus/bin/sayvars.sh,v  <--  sayvars.sh
new revision: 1.3; previous revision: 1.2
done
Checking in bin/set-build-env.sh;
/cvsroot/mozilla/testing/sisyphus/bin/set-build-env.sh,v  <--  set-build-env.sh
new revision: 1.4; previous revision: 1.3
done
Checking in bin/smoke-build.sh;
/cvsroot/mozilla/testing/sisyphus/bin/smoke-build.sh,v  <--  smoke-build.sh
new revision: 1.3; previous revision: 1.2
done
Checking in bin/test-setup.sh;
/cvsroot/mozilla/testing/sisyphus/bin/test-setup.sh,v  <--  test-setup.sh
new revision: 1.5; previous revision: 1.4
done
Checking in bin/tester.sh;
/cvsroot/mozilla/testing/sisyphus/bin/tester.sh,v  <--  tester.sh
new revision: 1.5; previous revision: 1.4
done
Checking in bin/uninstall-build.sh;
/cvsroot/mozilla/testing/sisyphus/bin/uninstall-build.sh,v  <--  uninstall-build.sh
new revision: 1.3; previous revision: 1.2
done
Checking in tests/mozilla.org/download-page/test.sh;
/cvsroot/mozilla/testing/sisyphus/tests/mozilla.org/download-page/test.sh,v  <--  test.sh
new revision: 1.4; previous revision: 1.3
done

Comment 5

[Bob Clary [:bc] (inactive)]

Attachment: updated patch for js/tests/*.sh to use /bin/bash

as checked in.

attachment 283551 [details] [diff] [review]: patch for js/tests/*.sh to use /bin/bash was missing the patch for runtests.sh.

Checking in test-browser.sh;
/cvsroot/mozilla/js/tests/test-browser.sh,v  <--  test-browser.sh
new revision: 1.5; previous revision: 1.4
done
Checking in test-shell.sh;
/cvsroot/mozilla/js/tests/test-shell.sh,v  <--  test-shell.sh
new revision: 1.5; previous revision: 1.4
done
Checking in test.sh;
/cvsroot/mozilla/js/tests/test.sh,v  <--  test.sh
new revision: 1.4; previous revision: 1.3
done
Checking in runtests.sh;
/cvsroot/mozilla/js/tests/runtests.sh,v  <--  runtests.sh
new revision: 1.2; previous revision: 1.1
done

Comment 6

[(not currently active) Ted Mielczarek]

Mass move of Sisyphus bugs to Testing : Sisyphus. Filter on SisyphusMassMove to ignore.