Closed Bug 397964 Opened 12 years ago Closed 11 years ago

Remove nsPostUpdateWin.js

Categories

(Toolkit :: Application Update, defect)

x86
Windows Vista
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: robert.strong.bugs, Unassigned)

References

Details

Attachments

(2 files, 1 obsolete file)

With the landing of bug 368587 on the branch we can remove nsPostUpdateWin.js since the only way a user can update to 3.0 via software update is after they have installed the latest 2.0.0.x.
Product: Firefox → Toolkit
Assignee: nobody → robert.bugzilla
Thunderbird no longer needs this.
The SeaMonkey bug to remove the dependency on this file is bug 390344.
Sunbird currently doesn't launch a postupdate process so it doesn't block.

Reassigning back to default since it is unknown when bug 390344 will be fixed.
Assignee: robert.bugzilla → nobody
btw: the Thunderbird bug that removed the dependency is bug 404609
Attached patch patch in progress (obsolete) — Splinter Review
Bug 459615 contains part of this cleanup... nsXULAppInfo::PostUpdate should also be removed from nsAppRunner.cpp after bug 459615 lands
Attachment #354427 - Attachment is patch: true
Attachment #354427 - Attachment mime type: application/octet-stream → text/plain
Attachment #355084 - Attachment description: patch in progress rev2 → patch rev1
Attachment #355084 - Flags: review?(dtownsend)
Target Milestone: --- → mozilla1.9.2a1
Comment on attachment 355085 [details] [diff] [review]
comm-central patch (checked in)

Frank, could I get you to review the Seamonkey portion of the comm-central patch?
Attachment #355085 - Attachment description: comm-central patch in progress (not tested yet) → comm-central patch in progress
Attachment #355085 - Flags: review?(bugzilla)
Comment on attachment 355085 [details] [diff] [review]
comm-central patch (checked in)

Phil, could I get you to review the Thunderbird portion of the comm-central patch?
Attachment #355085 - Flags: review?(philringnalda)
Comment on attachment 355085 [details] [diff] [review]
comm-central patch (checked in)

Clint, could I get you to review the Sunbird portion of the comm-central patch?
Attachment #355085 - Flags: review?(philringnalda) → review+
Comment on attachment 355085 [details] [diff] [review]
comm-central patch (checked in)

Works for me, thanks.
Attachment #355085 - Flags: review?(bugzilla) → review+
Comment on attachment 355085 [details] [diff] [review]
comm-central patch (checked in)

I think SeaMonkey only released one alpha version without the installer changes needed, but we need it in that case :)
Attachment #355084 - Flags: review?(dtownsend) → review+
Attachment #355085 - Flags: review?(ctalbert) → review+
Comment on attachment 355085 [details] [diff] [review]
comm-central patch (checked in)

r=ctalbert WFM, thanks!
Comment on attachment 355084 [details] [diff] [review]
patch rev1 (checked in)

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/cf4443001e7c
Attachment #355084 - Attachment description: patch rev1 → patch rev1 (checked in)
Comment on attachment 355085 [details] [diff] [review]
comm-central patch (checked in)

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/cf03581c50a0
Attachment #355085 - Attachment description: comm-central patch in progress → comm-central patch (checked in)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.