397982 - Default spellchecker to load dictionaries from GRE folder not APP folder

Status: RESOLVED FIXED

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Created attachment 282804 [details] [diff] [review]
Make spellchecker use NS_GRE_DIR as default dictionary root

Spellchecker fails to load dictionaries for XULRunner applications. This is because XULRunner ships the spellchecker dictionaries in the "dictionaries" subfolder of the XULRunner distribution. Without dictionaries, no spellcheck functionality is present.

The spellchecker tries to locate the dictionaries using the "XCurProcD" (launching process) folder as the root. This works fine for Firefox, Thunderbird, and other libxul apps because the GRE folder is the "XCurProcD" folder. But this fails for XULRunner apps, since the "XCurProcD" is rarely ever the "xulrunner" folder.

Changing the spellchecker to default to load from the GRE folder fixes the problem for XULRunner and doesn't break libxul apps like Firefox and Thunderbird.

Comment 1

[Benjamin Smedberg]

Comment on attachment 282804 [details] [diff] [review]
Make spellchecker use NS_GRE_DIR as default dictionary root

It's a little unfortunate that we can't load dictionaries from both XR and the app... could you add that here or in mozHunspellDirProvider? Or re-request review if that is unfeasible for some reason.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Created attachment 283053 [details] [diff] [review]
default to gre folder and app folder (if not same as gre folder)

This patch is the same as the previous patch except it also checks the app folder for dictionaries.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

new revision: 1.4; previous revision: 1.3