Closed Bug 397982 Opened 14 years ago Closed 14 years ago

Default spellchecker to load dictionaries from GRE folder not APP folder

Categories

(Core :: Spelling checker, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file, 1 obsolete file)

Spellchecker fails to load dictionaries for XULRunner applications. This is because XULRunner ships the spellchecker dictionaries in the "dictionaries" subfolder of the XULRunner distribution. Without dictionaries, no spellcheck functionality is present.

The spellchecker tries to locate the dictionaries using the "XCurProcD" (launching process) folder as the root. This works fine for Firefox, Thunderbird, and other libxul apps because the GRE folder is the "XCurProcD" folder. But this fails for XULRunner apps, since the "XCurProcD" is rarely ever the "xulrunner" folder.

Changing the spellchecker to default to load from the GRE folder fixes the problem for XULRunner and doesn't break libxul apps like Firefox and Thunderbird.
Attachment #282804 - Flags: review?(benjamin)
Assignee: mscott → mark.finkle
OS: Windows XP → All
Hardware: PC → All
Comment on attachment 282804 [details] [diff] [review]
Make spellchecker use NS_GRE_DIR as default dictionary root

It's a little unfortunate that we can't load dictionaries from both XR and the app... could you add that here or in mozHunspellDirProvider? Or re-request review if that is unfeasible for some reason.
Attachment #282804 - Flags: review?(benjamin)
This patch is the same as the previous patch except it also checks the app folder for dictionaries.
Attachment #282804 - Attachment is obsolete: true
Attachment #283053 - Flags: review?(benjamin)
Attachment #283053 - Flags: review?(benjamin) → review+
Attachment #283053 - Flags: approval1.9?
Attachment #283053 - Flags: approval1.9? → approval1.9+
new revision: 1.4; previous revision: 1.3
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.