Closed
Bug 398059
Opened 18 years ago
Closed 18 years ago
LDAP autocomplete should re-use nsAbLDAPListenerBase class
Categories
(MailNews Core :: Address Book, defect)
MailNews Core
Address Book
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Keywords: memory-footprint)
Attachments
(1 file)
|
35.04 KB,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
The LDAP autocomplete code duplicates a lot of what is in nsAbLDAPListenerBase. We should reuse it to reduce footprint and make maintenance of the auth/LDAP connections easier.
The attached patch does the required changes. Note that the authPrompter is no longer required as nsAbLDAPListenerBase already gets one itself.
I've also included a change to nsAbLDAPReplicationData that I'd missed in the previous preparation patch I did for this (bug 397801).
The object relationships should be pretty much the same with the revised class as they were before as we're basically "moving" a few things into the nsAbLDAPListenerBase class.
Attachment #282891 -
Flags: superreview?(bienvenu)
Attachment #282891 -
Flags: review?(bienvenu)
|
||
Comment 1•18 years ago
|
||
Comment on attachment 282891 [details] [diff] [review]
Do the merge
nice, Mark!
Attachment #282891 -
Flags: superreview?(bienvenu)
Attachment #282891 -
Flags: superreview+
Attachment #282891 -
Flags: review?(bienvenu)
Attachment #282891 -
Flags: review+
|
Assignee | |
Comment 2•18 years ago
|
||
Patch checked in -> fixed.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•