398101 - Dynamically inserting a space does not cause proper re-wrapping

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect, P2)

Description

[Jesse Ruderman]

Inserting a space text node between "b" and "c" should allow the "b" to move to the previous line, but the "b" doesn't move.

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Jesse Ruderman]

Attachment: reference

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This is annoyingly hard to fix.

The problem is that linebreak changes (or more generally, (re)construction of a textrun) should ensure that all frames associated with the textrun are reflowed.

This is particularly hard to ensure for frames that have already been reflowed in the current reflow pass.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

... but hang on, in this case we should be dirtying the previous line independent of textrun issues.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Be more diligent about invalidating textruns for lines, and especially, dirtying and invalidating text runs for previous-lines that may be able to pull up content.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 283328 [details] [diff] [review]
fix

r+sr=dbaron

Comment 7

[Reed Loden [:reed]]

Checking in layout/generic/nsBlockFrame.cpp;
/cvsroot/mozilla/layout/generic/nsBlockFrame.cpp,v  <--  nsBlockFrame.cpp
new revision: 3.885; previous revision: 3.884
done
Checking in layout/generic/nsBlockFrame.h;
/cvsroot/mozilla/layout/generic/nsBlockFrame.h,v  <--  nsBlockFrame.h
new revision: 3.256; previous revision: 3.255
done

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Jesse's reftest, to check in when I get a chance