398118 - MochiKit's isArrayLike needs to deal with windows

Status: REOPENED

(Testing :: Mochitest, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

See bug 398109 comment 0.

STEPS TO REPRODUCE:
1. Add |is(window, 'not correct', "failing testcase");| to a MochiTest
2. Run said MochiTest.

EXPECTED RESULTS:
The MochiTest should fail saying:
...expected: not correct, got: [object Window]...

ACTUAL RESULTS:
The MochiTest fails saying:
...expected: not correct, got: []...

The reason is that windows have a |length| property, so when the repr code attempts to look up the window in the reprRegistry, isArrayLike returns true, giving the unexpected, incorrect result. Presumably, isArrayLike needs to special case windows.

Comment 1

[Andrew Halberstadt [:ahal]]

Mass closing mochitest bugs that haven't had activity in the past 5 years. Please re-open or file a new bug with modern context if this is still relevant.

Comment 2

[Boris Zbarsky [:bzbarsky]]

This is still relevant; it's not like we changed any of the mochikit code.  I'm not sure what "modern context" you want.