398143 - Dragging scrollbar with mouse while autocomplete input has focus triggers autocomplete

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Martijn Wargers (dead)]

To reproduce:
- Open google.com (make sure you have autocomplete entries)
- Make window very small to get scrollbars
- Focus text input
- Click (or drag) on the scrollbar

Actual result:
Autocomplete popup appears.

Expected result:
No autocomplete popup appears.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Martijn Wargers (dead)]

Attachment: patch

This basically adds the check back in that was that the target element is an input element, which was there already before I removed it in bug 256856.
I don't need a check for targetInput != mFocusedInput, e.g., focusing another input with mousedown doesn't trigger autocomplet, but I could add it too, if you prefer.

Comment 4

[u88484]

MW, in my bug the autocomplete detaches from the input field. Will your patch fix that also? I don't see it mentioned in this report...thats why I'm asking. I had a screenshot in the duped bug showing that and the url you don't have to resize and causes the detaching.

Comment 5

[u88484]

Never mind I finally got the testcase to work and see it is the exact same bug. Sorry about the bug spam.

Comment 6

[Martijn Wargers (dead)]

No problem, I just hope that Mano can get this reviewed quickly to prevent dupe harvesting.

Comment 7

[Asaf Romano (gone)]

Comment on attachment 283008 [details] [diff] [review]
patch

r=mano.

Comment 8

[Martijn Wargers (dead)]

Comment on attachment 283008 [details] [diff] [review]
patch

Thanks for the quick review!

Comment 9

[Martijn Wargers (dead)]

Checking in nsFormFillController.cpp;
/cvsroot/mozilla/toolkit/components/satchel/src/nsFormFillController.cpp,v  <--
 nsFormFillController.cpp
new revision: 1.92; previous revision: 1.91
done

Checked in on trunk.