If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

rebuild search bar dropdown onpopupshowing, not at startup

RESOLVED FIXED in Firefox 3 beta1

Status

()

Firefox
Search
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

({perf})

Trunk
Firefox 3 beta1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

 
Created attachment 283048 [details] [diff] [review]
patch
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #283048 - Flags: review?
Attachment #283048 - Flags: review? → review?(mconnor)
Comment on attachment 283048 [details] [diff] [review]
patch

this seems wrong... :)
Attachment #283048 - Flags: review?(mconnor) → review-
Created attachment 283057 [details] [diff] [review]
better patch
Attachment #283057 - Flags: review?
Attachment #283048 - Attachment is obsolete: true
Attachment #283057 - Flags: review? → review?(mconnor)
The previous patch made us rebuild the popup for each popupshowing. This new one only rebuilds the popup on the first popupshowing, or when things have changed.
Comment on attachment 283057 [details] [diff] [review]
better patch

Hmm.  How about we remove the check from rebuildPopup, and check _needToRebuildPopup in rebuildPopupDynamic and then call rebuildPopup from there?  saves one function call on every popupshowing, and avoids having to set it from every caller
Attachment #283057 - Flags: review?(mconnor) → review+

Updated

10 years ago
Attachment #283057 - Flags: approval1.9?
Created attachment 283071 [details] [diff] [review]
with that change
Attachment #283057 - Attachment is obsolete: true
Attachment #283071 - Flags: approval1.9?
Attachment #283057 - Flags: approval1.9?

Updated

10 years ago
Attachment #283071 - Flags: approval1.9? → approval1.9+
mozilla/browser/components/search/content/search.xml 	1.104
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M9
Keywords: perf
You need to log in before you can comment on or make changes to this bug.