398218 - Download DB tracks -1 as the max size when resuming

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ed Lee :Mardak]

From bug 394548 comment #27:

1) warning about undefined behavior of multiple "i++" on the same line
3) main issue: DB tracks -1 as the max size when resuming, but the UI is fine

Comment 1

[Ed Lee :Mardak]

Attachment: followup v1.2 from bug 394548

This patch is r+ sdwilsh

Comment 2

[Ed Lee :Mardak]

Checking in toolkit/components/downloads/src/nsDownloadManager.cpp;
/cvsroot/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp,v  <--  nsDownloadManager.cpp
new revision: 1.133; previous revision: 1.132
done

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Edward: is there a Litmus-based testcase for this?  In comment 0, you say that "the UI is fine"; would this show up as corrupt downloads for larger files?

Comment 4

[Ed Lee :Mardak]

Well, you could query the DB with something like the mozstorage explorer extension. I can't think of something from a vanilla install of trunk.

Comment 5

[Shawn Wilsher :sdwilsh]

hey - you are supposed to set the flags when you checkin :p

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #5)
> hey - you are supposed to set the flags when you checkin :p

Yes, he is, except not "verified," :-) 

Comment 7

[Shawn Wilsher :sdwilsh]

Except that I actually meant to verify that it was fixed!

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

My bad, dude; restoring flag :-)