Closed
Bug 398247
Opened 17 years ago
Closed 17 years ago
[TodayPane] toolbar button icons in miniday are left aligned
Categories
(Calendar :: Calendar Frontend, defect)
Calendar
Calendar Frontend
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: berend.cornelius09, Assigned: berend.cornelius09)
Details
Attachments
(1 file, 1 obsolete file)
3.15 KB,
patch
|
Details | Diff | Splinter Review |
The navigation buttons ("< 0 >") and the dropdown button to invoke the minimonth are not centered orderly. Especially under Windows and Mac this is quite obvious.
Assignee | ||
Comment 1•17 years ago
|
||
Attachment #283159 -
Flags: ui-review?(christian.jansen)
Comment 2•17 years ago
|
||
See Bug 397920 for similar issue but with right aligned images.
Assignee | ||
Updated•17 years ago
|
OS: SunOS → All
Comment 3•17 years ago
|
||
Comment on attachment 283159 [details] [diff] [review] patch that centers the toolbar-icons ui=christian
Comment 4•17 years ago
|
||
Comment on attachment 283159 [details] [diff] [review] patch that centers the toolbar-icons ui=christian
Attachment #283159 -
Flags: ui-review?(christian.jansen) → ui-review+
Assignee | ||
Comment 5•17 years ago
|
||
Comment on attachment 283159 [details] [diff] [review] patch that centers the toolbar-icons mickey, in this case I thought it would be better to do the UI review before. As this has been granted, could you do the review?
Attachment #283159 -
Flags: review?(michael.buettner)
Comment 6•17 years ago
|
||
(In reply to comment #5) > mickey, in this case I thought it would be better to do the UI review before. > As this has been granted, could you do the review? Berend, I'm currently investigating the remaining 0.7 blocker bugs. Certainly, I have this and all the other bugs on my radar, I'm going to do the review as soon as I get to it.
Comment 7•17 years ago
|
||
Comment on attachment 283159 [details] [diff] [review] patch that centers the toolbar-icons The rule in the pinstripe css file that prevents the display of the toolbarbutton-text is also important for the winstripe case. At least under WinXP SP2 the icons were still left aligned without it. > #miniday-dropdown-button > .toolbarbutton-text, > .miniday-nav-buttons > .toolbarbutton-text { > display: none; > } Please add the above rule to the winstripe/today-pane.css file, apart from that the patch looks fine -> r=mickey
Attachment #283159 -
Flags: review?(michael.buettner) → review+
Assignee | ||
Updated•17 years ago
|
Whiteboard: [checkin-needed after 0.7]
Updated•17 years ago
|
Status: NEW → ASSIGNED
Target Milestone: Future → ---
Version: Trunk → unspecified
Assignee | ||
Comment 8•17 years ago
|
||
checked in on trunk and MOZILLA_1_8_BRANCH
Attachment #283159 -
Attachment is obsolete: true
Assignee | ||
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Whiteboard: [checkin-needed after 0.7]
Target Milestone: --- → 0.8
You need to log in
before you can comment on or make changes to this bug.
Description
•