398303 - Attendees preview is broken in new event summary dialog

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Omar Bajraszewski]

Attachment: Screenshot

Opening a summary dialog for event with attendees shows all available icons next to attendee:

1) Subscribe to Firefox Team calendar (http://www.google.com/calendar/ical/[e-mail]/public/basic.ics)
2) Mark the calendar as read only
3) Open 'Leek Status Meeting' on 2nd of October

Result:
see attached screenshot

Comment 1

[Omar Bajraszewski]

Tested with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.8pre) Gecko/20071001 Sunbird/0.7 and lightning 2007100203

Comment 2

[Daniel Boelzle [:dbo]]

needs to be investigated for 0.7

Comment 3

[Michael Büttner (no reviews TFN)]

The summary dialog sets the 'status'-attribute for each attendee icon image to the corresponding participation status of each attendee object, see [1]. This gets picked up by the css rules for the image, see [2]. Admittedly, if the participation status contains any value for which we don't have a matching css rule, we currently just display the whole image. In this particular case the participation status contains "ORGANIZER".

RFC 2445 states that the following participation status values can be defined for a VEVENT:

"NEEDS-ACTION"
"ACCEPTED"
"DECLINED"
"TENTATIVE"
"DELEGATED"

We also don't have an image (and therefore no rule for DELEGATED), which will cause the same problem has any bogus value. A short-term solution could be to don't display an icon image in such cases. Daniel, what's your opinion on that?

[1] http://lxr.mozilla.org/mozilla1.8/source/calendar/base/content/calendar-summary-dialog.js#294
[2] http://lxr.mozilla.org/mozilla1.8/source/calendar/base/themes/winstripe/calendar-event-dialog.css#54

Comment 4

[Michael Büttner (no reviews TFN)]

Attachment: patch v1

This patch suppresses the display of the attendee icon image for unknown participation status values, i.e. those we currently don't have an image for.

Comment 5

[Daniel Boelzle [:dbo]]

(In reply to comment #3)
...
> We also don't have an image (and therefore no rule for DELEGATED), which will
> cause the same problem has any bogus value. A short-term solution could be to
> don't display an icon image in such cases. Daniel, what's your opinion on that?
I'm fine with that. Christian/Stella may propose a different icon in the future, e.g. a question mark.

Comment 6

[Daniel Boelzle [:dbo]]

Comment on attachment 283537 [details] [diff] [review]
patch v1

r=dbo

Comment 7

[Michael Büttner (no reviews TFN)]

patch checked in on trunk, MOZILLA_1_8_BRANCH and SUNBIRD_0_7_BRANCH

-> FIXED

Comment 8

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.1.8pre) Gecko/20071002 Sunbird/0.7

Comment 9

[Omar Bajraszewski]

Damian, how can you verify this bug with that build (and the same with Bug 375390)? It was reported with 20071002 build

Comment 10

[Omar Bajraszewski]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.8pre) Gecko/20071006 Sunbird/0.7
and
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007100601 Calendar/0.6a1