398330 - "(Empty)" bookmark menu items have parent folder icons in firefox and "Copy Here" menu items have parent folder icons in thunderbird

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[(not reading, please use [e-mail] instead)]

"(Empty)" bookmark menu items have parent folder icons in firefox and "Copy Here" menu items have parent folder icons in thunderbird

let me attach some screen shots.

not 100% sure this is a mac bug or a firefox/thunderbird pinstripe issue yet.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: firefox bookmark menu screen shot

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: thunderbird menu screen shot

Comment 3

[(not reading, please use [e-mail] instead)]

hmm, the "File Here" menu item in thunderbird 2 does not seem to haves this problem, so it might, this may not be a widget bug at all.

Comment 4

[Phil Ringnalda (:philor)]

That would be http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/themes/pinstripe/global/menu.css&rev=1.12&mark=98#95 wouldn't it? Winstripe doesn't inherit list-style-image there, and the bug doesn't seem to say why Pinstripe is.

Comment 5

[(not reading, please use [e-mail] instead)]

phil, thanks for jumping in.

does that fix it for you?  

that doesn't seem to fix it for me.

note that the "(empty)" item does not have the class "menu-iconic-icon"

see http://lxr.mozilla.org/seamonkey/source/browser/components/places/content/menu.xml#291

Comment 6

[Phil Ringnalda (:philor)]

Hmm, indeed it doesn't. Certainly seems like it would be a Widget:Cocoa bug, then.

Comment 7

[(not reading, please use [e-mail] instead)]

phil, thanks for double checking.  note that in tbird mac 2.0, the "file here" menu does not have this icon.  (I haven't tried to figure out why yet.)

> Certainly seems like it would be a Widget:Cocoa bug

cc'ing some mac guys.

Comment 8

[Josh Aas]

I did some debugging in the Mac widget code, "chrome://global/skin/tree/folder.png" is actually set on the "(Empty)" menu item. That means this probably isn't a widget bug. That is pulled directly from the empty menu item's content node's "image" attr.

Comment 9

[Josh Aas]

Correction - that URI is set on the "(Empty)" menu item's content node, but it is set for the "list-style-image" attribute, not "image". There is no "image" attribute on the node. The mac menu item icon looks for both attributes, preferring "image" over "list-style-image".

I verified this in the mac widget code and by using DOM inspector.

Comment 10

[(not reading, please use [e-mail] instead)]

josh, thanks for doing some investigation.  

now to figure out what in our css is setting "list-style-image" for those menu items.

not a blocker, though.

Comment 11

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 12

[Stefan [:stefanh]]

So, this happens in SeaMonkey as well. When I look in DOMi, list-style-image is "none", but the widget code still thinks there's an image that should be displayed.

Comment 13

[Mark Banner (:standard8)]

I don't know when this changed, but windows now has a blank space for the image. Mac shows the default icon, but that's better than the folder icon.

I think we can mark this as WFM.