Closed Bug 398382 Opened 15 years ago Closed 15 years ago

A couple of missing or wrong control attributes for labels in places dialogs

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Firefox 3 beta1

People

(Reporter: MarcoZ, Assigned: MarcoZ)

Details

(Keywords: access)

Attachments

(1 file, 1 obsolete file)

In the Organize Bookmarks dialog, the Tags: textbox does not have a properly assigned accessible label. While fixing this, I found a few other places within that directory where such label/control associations are also missing.
Flags: blocking-firefox3?
Attached patch Patch (obsolete) — Splinter Review
This patch addresses the missing label/control associations, and corrects the control assignment for the "Tags:" textbox.
Attachment #283336 - Flags: review?(mano)
Attachment #283336 - Flags: approval1.9?
Attachment #283336 - Flags: approval1.9? → approval1.9+
Bug 398394 bitrotted this patch. The <label> for advancedSearch moved to advancedSearch.inc. Here's an updated patch that just corrects the <label> in the right file.
Attachment #283336 - Attachment is obsolete: true
Comment on attachment 283684 [details] [diff] [review]
patch (unbitrotted)

I don't think this needs review again since it's just dealing with the bitrot from bug 398394, but I'm requesting it. If it doesn't need review/approval again, just cancel the flags and add checkin-needed, and I'll get it tomorrow.
Attachment #283684 - Flags: review?(mano)
Attachment #283684 - Flags: approval1.9?
Summary: A couple of missing or wrong control attributes for labels in places dialogs. → A couple of missing or wrong control attributes for labels in places dialogs
Target Milestone: --- → Firefox 3 M9
Flags: blocking-firefox3? → blocking-firefox3+
Comment on attachment 283684 [details] [diff] [review]
patch (unbitrotted)

I don't think this needs review again. Looks fine to me. Requesting checkin.
Attachment #283684 - Flags: review?(mano)
Attachment #283684 - Flags: approval1.9?
Keywords: checkin-needed
Checking in browser/components/places/content/advancedSearch.inc;
/cvsroot/mozilla/browser/components/places/content/advancedSearch.inc,v  <--  advancedSearch.inc
new revision: 1.7; previous revision: 1.6
done
Checking in browser/components/places/content/editBookmarkOverlay.xul;
/cvsroot/mozilla/browser/components/places/content/editBookmarkOverlay.xul,v  <--  editBookmarkOverlay.xul
new revision: 1.6; previous revision: 1.5
done
Checking in browser/components/places/content/moveBookmarks.xul;
/cvsroot/mozilla/browser/components/places/content/moveBookmarks.xul,v  <--  moveBookmarks.xul
new revision: 1.6; previous revision: 1.5
done
Checking in browser/components/places/content/places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul
new revision: 1.90; previous revision: 1.89
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.