398382 - A couple of missing or wrong control attributes for labels in places dialogs

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Zehe (:MarcoZ)]

In the Organize Bookmarks dialog, the Tags: textbox does not have a properly assigned accessible label. While fixing this, I found a few other places within that directory where such label/control associations are also missing.

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Patch

This patch addresses the missing label/control associations, and corrects the control assignment for the "Tags:" textbox.

Comment 2

[Asaf Romano (gone)]

Comment on attachment 283336 [details] [diff] [review]
Patch

r=mano

Comment 3

[Reed Loden [:reed]]

Attachment: patch (unbitrotted)

Bug 398394 bitrotted this patch. The <label> for advancedSearch moved to advancedSearch.inc. Here's an updated patch that just corrects the <label> in the right file.

Comment 4

[Reed Loden [:reed]]

Comment on attachment 283684 [details] [diff] [review]
patch (unbitrotted)

I don't think this needs review again since it's just dealing with the bitrot from bug 398394, but I'm requesting it. If it doesn't need review/approval again, just cancel the flags and add checkin-needed, and I'll get it tomorrow.

Comment 5

[Marco Zehe (:MarcoZ)]

Comment on attachment 283684 [details] [diff] [review]
patch (unbitrotted)

I don't think this needs review again. Looks fine to me. Requesting checkin.

Comment 6

[Reed Loden [:reed]]

Checking in browser/components/places/content/advancedSearch.inc;
/cvsroot/mozilla/browser/components/places/content/advancedSearch.inc,v  <--  advancedSearch.inc
new revision: 1.7; previous revision: 1.6
done
Checking in browser/components/places/content/editBookmarkOverlay.xul;
/cvsroot/mozilla/browser/components/places/content/editBookmarkOverlay.xul,v  <--  editBookmarkOverlay.xul
new revision: 1.6; previous revision: 1.5
done
Checking in browser/components/places/content/moveBookmarks.xul;
/cvsroot/mozilla/browser/components/places/content/moveBookmarks.xul,v  <--  moveBookmarks.xul
new revision: 1.6; previous revision: 1.5
done
Checking in browser/components/places/content/places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul
new revision: 1.90; previous revision: 1.89
done

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv