[places] add "match" label to places search builder

VERIFIED FIXED

Status

()

Firefox
Bookmarks & History
--
trivial
VERIFIED FIXED
10 years ago
8 years ago

People

(Reporter: wladow, Assigned: wladow)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9a9pre) Gecko/2007100205 Minefield/3.0a9pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9a9pre) Gecko/2007100205 Minefield/3.0a9pre

After landing Bug 387744 there is no "Match" label in places search builder

There should be line "Match all/any of the following rules:", but currently it is "all/any of the following rules:"

Reproducible: Always
(Assignee)

Comment 1

10 years ago
Created attachment 283342 [details] [diff] [review]
patch for adding "match" label
(Assignee)

Updated

10 years ago
Version: unspecified → Trunk
Comment on attachment 283342 [details] [diff] [review]
patch for adding "match" label

thanks for the patch! can you please also remove it's old location:

http://mxr.mozilla.org/seamonkey/source/browser/components/places/content/places.xul#378
(Assignee)

Comment 3

10 years ago
Created attachment 283449 [details] [diff] [review]
patch for adding "match" label v2

I think, there is more cleanup needed in places.xul, not just this line. At least, whole hbox in http://mxr.mozilla.org/seamonkey/source/browser/components/places/content/places.xul#378 should go away, it is the same like in http://mxr.mozilla.org/seamonkey/source/browser/components/places/content/advancedSearch.inc#38
Attachment #283342 - Attachment is obsolete: true
(In reply to comment #3)
> Created an attachment (id=283449) [details]
> patch for adding "match" label v2
> 
> I think, there is more cleanup needed in places.xul, not just this line. At
> least, whole hbox in
> http://mxr.mozilla.org/seamonkey/source/browser/components/places/content/places.xul#378
> should go away, it is the same like in
> http://mxr.mozilla.org/seamonkey/source/browser/components/places/content/advancedSearch.inc#38
> 

yes, the whole hbox can be removed.
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 5

10 years ago
Created attachment 283454 [details] [diff] [review]
patch for adding "match" label v3

ok, here is a patch with removing whole hbox.
Attachment #283449 - Attachment is obsolete: true
Comment on attachment 283454 [details] [diff] [review]
patch for adding "match" label v3

requesting approval - removes unused hidden UI code, as well as fixing a minor regression from bug 38744.
Attachment #283454 - Flags: review+
Attachment #283454 - Flags: approval1.9?

Updated

10 years ago
Attachment #283454 - Flags: approval1.9? → approval1.9+
Checking in browser/components/places/content/advancedSearch.inc;
/cvsroot/mozilla/browser/components/places/content/advancedSearch.inc,v  <--  advancedSearch.inc
new revision: 1.6; previous revision: 1.5
done
Checking in browser/components/places/content/places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul
new revision: 1.89; previous revision: 1.88
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Assignee: nobody → valastiak
(Assignee)

Comment 8

10 years ago
verified using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007100505 Minefield/3.0a9pre
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.