Closed Bug 398407 Opened 15 years ago Closed 15 years ago

Animated gif images only working once on mouseover/mouseout

Categories

(Core :: ImageLib, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: martijn.martijn, Assigned: asmith16)

References

()

Details

(Keywords: regression, testcase)

Attachments

(4 files)

This came from Hendrix feedback:
http://groups.google.com/group/mozilla.feedback/browse_thread/thread/401ce718a9bb2d4f/788da02927c5c415

When hovering over the icons in the right sidebar, they don't animate anymore in current trunk build.
They do animate in branch builds.

This regressed between 2007-03-20 and 2007-03-21:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-03-20+04&maxdate=2007-03-21+09&cvsroot=%2Fcvsroot
Regression from bug 257197?
Attached file testcase
Flags: blocking1.9?
FWIW, I think that what's happening here is that we're going through a number of intermediate frames very quickly, and the invalidation isn't happening.  There are a number of animation-related issues (not necessarily animated images, including DHTML animation) that sound similar to this on trunk -- the DHTML tests without browser chrome exhibit the same problems.
Flags: blocking1.9? → blocking1.9+
i'll work on it
Assignee: nobody → asmith15
Attached patch fixSplinter Review
sorry about that, it's (almost) a typo from the apng patch.

it's a one-liner, can you please take a quick look stuart?
Attachment #283415 - Flags: review?(pavlov)
Attachment #283415 - Flags: review?(pavlov)
Attachment #283415 - Flags: review+
Attachment #283415 - Flags: approval1.9+
Keywords: checkin-needed
Checking in imgContainer.cpp;
/cvsroot/mozilla/modules/libpr0n/src/imgContainer.cpp,v  <--  imgContainer.cpp
new revision: 1.53; previous revision: 1.52
done

Checked into trunk.
Wow, this was a quickie, thanks Andrew.
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007100705 Minefield/3.0a9pre
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
I added a test for this in litmus: http://litmus.mozilla.org/show_test.cgi?id=4711
But ideally this should be done in one of the testsuites (reftest, I think) and then the litmus test could be removed, I think.
Flags: in-litmus+
You need to log in before you can comment on or make changes to this bug.