Closed Bug 398435 Opened 12 years ago Closed 12 years ago

PRBool misuse bugs in xpcom/

Categories

(Core :: XPCOM, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9beta1

People

(Reporter: taras.mozilla, Assigned: taras.mozilla)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch prbool corrections in xpcom (obsolete) — Splinter Review
Manually corrected patch produced by prcheck.
Attachment #283401 - Flags: review?(benjamin)
Status: NEW → ASSIGNED
Assignee: nobody → tglek
Status: ASSIGNED → NEW
Updated 0 != to !!. Added a 4 more hunks with manual fixes for stuff that prcheck didn't rewrite due to macros.
Attachment #283401 - Attachment is obsolete: true
Attachment #283756 - Flags: review?(benjamin)
Attachment #283401 - Flags: review?(benjamin)
Attachment #283756 - Flags: review?(benjamin) → review+
Attachment #283756 - Flags: approval1.9?
Attachment #283756 - Flags: approval1.9? → approval1.9+
Attachment #283756 - Attachment is obsolete: true
Checking in xpcom/ds/nsHashtable.cpp;
/cvsroot/mozilla/xpcom/ds/nsHashtable.cpp,v  <--  nsHashtable.cpp
new revision: 3.69; previous revision: 3.68
done
Checking in xpcom/glue/nsBaseHashtable.h;
/cvsroot/mozilla/xpcom/glue/nsBaseHashtable.h,v  <--  nsBaseHashtable.h
new revision: 3.15; previous revision: 3.14
done
Checking in xpcom/glue/nsTHashtable.h;
/cvsroot/mozilla/xpcom/glue/nsTHashtable.h,v  <--  nsTHashtable.h
new revision: 3.20; previous revision: 3.19
done
Checking in xpcom/glue/nsThreadUtils.cpp;
/cvsroot/mozilla/xpcom/glue/nsThreadUtils.cpp,v  <--  nsThreadUtils.cpp
new revision: 1.3; previous revision: 1.2
done
Checking in xpcom/io/nsBinaryStream.cpp;
/cvsroot/mozilla/xpcom/io/nsBinaryStream.cpp,v  <--  nsBinaryStream.cpp
new revision: 1.30; previous revision: 1.29
done
Checking in xpcom/io/nsEscape.cpp;
/cvsroot/mozilla/xpcom/io/nsEscape.cpp,v  <--  nsEscape.cpp
new revision: 1.39; previous revision: 1.38
done
Checking in xpcom/io/nsPipe3.cpp;
/cvsroot/mozilla/xpcom/io/nsPipe3.cpp,v  <--  nsPipe3.cpp
new revision: 1.27; previous revision: 1.26
done
Checking in xpcom/io/nsScriptableInputStream.cpp;
/cvsroot/mozilla/xpcom/io/nsScriptableInputStream.cpp,v  <--  nsScriptableInputStream.cpp
new revision: 1.12; previous revision: 1.11
done
Checking in xpcom/proxy/src/nsProxyEvent.cpp;
/cvsroot/mozilla/xpcom/proxy/src/nsProxyEvent.cpp,v  <--  nsProxyEvent.cpp
new revision: 1.96; previous revision: 1.95
done
Checking in xpcom/proxy/src/nsProxyEventPrivate.h;
/cvsroot/mozilla/xpcom/proxy/src/nsProxyEventPrivate.h,v  <--  nsProxyEventPrivate.h
new revision: 1.53; previous revision: 1.52
done
Checking in xpcom/reflect/xptinfo/public/xptinfo.h;
/cvsroot/mozilla/xpcom/reflect/xptinfo/public/xptinfo.h,v  <--  xptinfo.h
new revision: 1.29; previous revision: 1.28
done
Checking in xpcom/reflect/xptinfo/src/xptiManifest.cpp;
/cvsroot/mozilla/xpcom/reflect/xptinfo/src/xptiManifest.cpp,v  <--  xptiManifest.cpp
new revision: 1.33; previous revision: 1.32
done
Checking in xpcom/typelib/xpt/public/xpt_struct.h;
/cvsroot/mozilla/xpcom/typelib/xpt/public/xpt_struct.h,v  <--  xpt_struct.h
new revision: 1.51; previous revision: 1.50
done
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Backed out as part of wack-a-Tp-mole.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Relanded.

Checking in xpcom/ds/nsHashtable.cpp;
/cvsroot/mozilla/xpcom/ds/nsHashtable.cpp,v  <--  nsHashtable.cpp
new revision: 3.71; previous revision: 3.70
done
Checking in xpcom/glue/nsBaseHashtable.h;
/cvsroot/mozilla/xpcom/glue/nsBaseHashtable.h,v  <--  nsBaseHashtable.h
new revision: 3.17; previous revision: 3.16
done
Checking in xpcom/glue/nsTHashtable.h;
/cvsroot/mozilla/xpcom/glue/nsTHashtable.h,v  <--  nsTHashtable.h
new revision: 3.22; previous revision: 3.21
done
Checking in xpcom/glue/nsThreadUtils.cpp;
/cvsroot/mozilla/xpcom/glue/nsThreadUtils.cpp,v  <--  nsThreadUtils.cpp
new revision: 1.5; previous revision: 1.4
done
Checking in xpcom/io/nsBinaryStream.cpp;
/cvsroot/mozilla/xpcom/io/nsBinaryStream.cpp,v  <--  nsBinaryStream.cpp
new revision: 1.32; previous revision: 1.31
done
Checking in xpcom/io/nsEscape.cpp;
/cvsroot/mozilla/xpcom/io/nsEscape.cpp,v  <--  nsEscape.cpp
new revision: 1.41; previous revision: 1.40
done
Checking in xpcom/io/nsPipe3.cpp;
/cvsroot/mozilla/xpcom/io/nsPipe3.cpp,v  <--  nsPipe3.cpp
new revision: 1.29; previous revision: 1.28
done
Checking in xpcom/io/nsScriptableInputStream.cpp;
/cvsroot/mozilla/xpcom/io/nsScriptableInputStream.cpp,v  <--  nsScriptableInputStream.cpp
new revision: 1.14; previous revision: 1.13
done
Checking in xpcom/proxy/src/nsProxyEvent.cpp;
/cvsroot/mozilla/xpcom/proxy/src/nsProxyEvent.cpp,v  <--  nsProxyEvent.cpp
new revision: 1.98; previous revision: 1.97
done
Checking in xpcom/proxy/src/nsProxyEventPrivate.h;
/cvsroot/mozilla/xpcom/proxy/src/nsProxyEventPrivate.h,v  <--  nsProxyEventPrivate.h
new revision: 1.55; previous revision: 1.54
done
Checking in xpcom/reflect/xptinfo/public/xptinfo.h;
/cvsroot/mozilla/xpcom/reflect/xptinfo/public/xptinfo.h,v  <--  xptinfo.h
new revision: 1.31; previous revision: 1.30
done
Checking in xpcom/reflect/xptinfo/src/xptiManifest.cpp;
/cvsroot/mozilla/xpcom/reflect/xptinfo/src/xptiManifest.cpp,v  <--  xptiManifest.cpp
new revision: 1.35; previous revision: 1.34
done
Checking in xpcom/typelib/xpt/public/xpt_struct.h;
/cvsroot/mozilla/xpcom/typelib/xpt/public/xpt_struct.h,v  <--  xpt_struct.h
new revision: 1.53; previous revision: 1.52
done
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
You need to log in before you can comment on or make changes to this bug.