Closed
Bug 398443
Opened 17 years ago
Closed 16 years ago
actions icons should be aligned in Applications prefpane
Categories
(Firefox :: File Handling, defect, P4)
Firefox
File Handling
Tracking
()
RESOLVED
FIXED
People
(Reporter: myk, Assigned: florian)
References
Details
(Whiteboard: [proto])
Attachments
(1 file)
865 bytes,
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
In the Applications prefpane, the icons in the actions dropdown menu aren't aligned with the icon for the menu's selected item or the icons for the chosen applications for other types. To make the prefpane look better, all three types of icons should be aligned with each other.
Comment 1•17 years ago
|
||
Nominating as I suspect this is probably "wanted Firefox3".
Flags: blocking-firefox3?
Updated•17 years ago
|
Whiteboard: [proto]
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P4
Updated•17 years ago
|
Assignee: nobody → florian
Assignee | ||
Comment 2•17 years ago
|
||
This has been mostly fixed by my patch in bug 398445. The icons are now aligned on Windows and Mac. Apparently the patch got slightly bitrotted in the gnomestripe part by the time it got reviewed so I'll fix the remaining Linux issue here.
Assignee | ||
Updated•17 years ago
|
Whiteboard: [proto] → [proto][needs patch]
Assignee | ||
Comment 4•17 years ago
|
||
Trivial patch to fix the remaining alignment issues on Gnomestripe.
Attachment #295173 -
Flags: review?(mano)
Assignee | ||
Updated•17 years ago
|
Whiteboard: [proto][needs patch] → [proto][needs review mano]
Comment 5•17 years ago
|
||
Why is !important needed here?
Assignee | ||
Comment 6•17 years ago
|
||
(In reply to comment #5) > Why is !important needed here? > This style rule was added in menu.css by bug 404751: .menu-iconic-left { -moz-padding-end: 3px !important; } We need the !important to override it.
Comment 7•16 years ago
|
||
Comment on attachment 295173 [details] [diff] [review] patch r=mano.
Attachment #295173 -
Flags: review?(mano) → review+
Assignee | ||
Comment 8•16 years ago
|
||
Checking in browser/themes/gnomestripe/browser/preferences/applications.css; /cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/applications.css,v <-- applications.css new revision: 1.2; previous revision: 1.1 done
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [proto][needs review mano] → [proto]
You need to log in
before you can comment on or make changes to this bug.
Description
•