398445 - eliminate jitter when selecting new item in Applications prefpane

Status: VERIFIED FIXED

(Firefox :: File Handling, defect, P4)

Description

[Myk Melez [:myk] [@mykmelez]]

In the Applications prefpane, when you select a new item from the list of types, there's a bit of jitter as that item expands and the formerly-selected item contracts.  We should eliminate that jitter by making all items the same height, if we can do so without making the selected item's height too short or the other items' heights too tall.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Nominating, as I suspect this is a wanted-firefox3 bug.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Blocking-P4

Comment 3

[Florian Quèze [:florian]]

Attachment: patch v1

This should fix this bug 398443, bug 398445 and bug 400217.

I tested on Mac OS 10.5, Windows XP and Vista, Ubuntu 7.10.

Comment 4

[Asaf Romano (gone)]

s/#/%/, these are css files (or you could avoid pre-processing it altogether).

Comment 5

[Florian Quèze [:florian]]

Attachment: patch v2

* s/#/*/ (license headers)
* s/0px/0/
* more rtl friendly

Comment 6

[Asaf Romano (gone)]

Hrm, you need to patch gnomestipe as well.

Comment 7

[Asaf Romano (gone)]

Hrm... ignore me...

Comment 8

[Asaf Romano (gone)]

mozilla/browser/components/preferences/handlers.css 1.2
mozilla/browser/components/preferences/handlers.xml 1.4
mozilla/browser/components/preferences/preferences.xul 1.16
mozilla/browser/themes/gnomestripe/browser/jar.mn 1.64
mozilla/browser/themes/gnomestripe/browser/preferences/applications.css initial revision: 1.1
mozilla/browser/themes/pinstripe/browser/jar.mn 1.66
mozilla/browser/themes/pinstripe/browser/preferences/applications.css initial revision: 1.1
mozilla/browser/themes/winstripe/browser/jar.mn 1.63
mozilla/browser/themes/winstripe/browser/preferences/applications.css initial revision: 1.1

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Tested default themes using the Applications prefpane on:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007120704 Minefield/3.0b2pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007120704 Minefield/3.0b2pre

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007120705 Minefield/3.0b2pre

-and-

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007120705 Minefield/3.0b2pre

florian++ :-)

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

(The last build ID should be Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007120705 Minefield/3.0b2pre; VMWare Fusion's copy/paste support can be temperamental at times.)

Comment 11

[Florian Quèze [:florian]]

I verified the result with nightly builds too.  As I noted in bug 398443 the result is not as good as I expected on Linux.  I will fix the remaining issue there.