Closed Bug 398445 Opened 14 years ago Closed 14 years ago

eliminate jitter when selecting new item in Applications prefpane

Categories

(Firefox :: File Handling, defect, P4)

defect

Tracking

()

VERIFIED FIXED
Firefox 3 beta2

People

(Reporter: myk, Assigned: florian)

References

Details

(Whiteboard: [proto])

Attachments

(1 file, 1 obsolete file)

In the Applications prefpane, when you select a new item from the list of types, there's a bit of jitter as that item expands and the formerly-selected item contracts.  We should eliminate that jitter by making all items the same height, if we can do so without making the selected item's height too short or the other items' heights too tall.
Blocks: 396293
Nominating, as I suspect this is a wanted-firefox3 bug.
Whiteboard: [proto]
Flags: blocking-firefox3?
Blocking-P4
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P4
Attached patch patch v1 (obsolete) — Splinter Review
This should fix this bug 398443, bug 398445 and bug 400217.

I tested on Mac OS 10.5, Windows XP and Vista, Ubuntu 7.10.
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #289773 - Flags: review?(mano)
s/#/%/, these are css files (or you could avoid pre-processing it altogether).
Attached patch patch v2Splinter Review
* s/#/*/ (license headers)
* s/0px/0/
* more rtl friendly
Attachment #289773 - Attachment is obsolete: true
Attachment #289773 - Flags: review?(mano)
Hrm, you need to patch gnomestipe as well.
mozilla/browser/components/preferences/handlers.css 1.2
mozilla/browser/components/preferences/handlers.xml 1.4
mozilla/browser/components/preferences/preferences.xul 1.16
mozilla/browser/themes/gnomestripe/browser/jar.mn 1.64
mozilla/browser/themes/gnomestripe/browser/preferences/applications.css initial revision: 1.1
mozilla/browser/themes/pinstripe/browser/jar.mn 1.66
mozilla/browser/themes/pinstripe/browser/preferences/applications.css initial revision: 1.1
mozilla/browser/themes/winstripe/browser/jar.mn 1.63
mozilla/browser/themes/winstripe/browser/preferences/applications.css initial revision: 1.1
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M10
Tested default themes using the Applications prefpane on:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007120704 Minefield/3.0b2pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007120704 Minefield/3.0b2pre

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007120705 Minefield/3.0b2pre

-and-

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007120705 Minefield/3.0b2pre

florian++ :-)
Status: RESOLVED → VERIFIED
(The last build ID should be Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007120705 Minefield/3.0b2pre; VMWare Fusion's copy/paste support can be temperamental at times.)
I verified the result with nightly builds too.  As I noted in bug 398443 the result is not as good as I expected on Linux.  I will fix the remaining issue there.
You need to log in before you can comment on or make changes to this bug.