398469 - Ctrl+arrows does not change search engine in search field

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[dfjana]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007100304 Minefield/3.0a9pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007100304 Minefield/3.0a9pre

In the most recent build (Gecko/2007100304 Minefield/3.0a9pre) using the Ctrl button and the up and down arrows does not go through the several search engines I have. This did work with yesterday's build.

Don't know if this matters but, I have removed all but Google Search and added a few others. 

Reproducible: Always

Steps to Reproduce:
1. Open Minefield
2. Go to search field
3. Ctrl+Up|Down arrow to go through search engines
Actual Results:  
The search engine already chosen (from last search) stays chosen, regardless of the ctrl+arrows.

Expected Results:  
Ctrl+Arrows should go through the installed search engines.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

This is a regression from the patch for bug 398184. Thanks for catching and reporting this so quickly! :)

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

selectEngine depended on rebuildPopup building the list of engines (this._engines). Moves the engines array to a lazily-updated property. None of this code is in the critical path (only called when an engine is selected with Ctrl+Up/Down or when engine details change).

Comment 3

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/content/search.xml 	1.106

Comment 4

[Carsten Book [:Tomcat]]

verified using  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2007122705 Minefield/3.0b3pre 

- Verified fixed