398565 - [App prefpane] Changing application to 'always ask' does not change the icon to generic (keeps previous icon)

Status: RESOLVED FIXED

(Firefox :: File Handling, defect)

Description

[u88484]

Attachment: Screenshot

In the application preference pane when you change the application for a content type that has an icon (like winzip, a xpi file set for Firefox) to 'always ask', the icon does not change from winzip's icon to the generic icon.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

I have a simple patch for this that I'll attach shortly.  It uses the generic application icon for the "always ask" and "save file" actions and ensures that the icon gets updated when the action changes.

But that seems suboptimal, since that icon doesn't accurately represent those actions.  cc:ing faaborg for his thoughts on more specific icons for them.

Requesting wanted-firefox3 for this polish bug.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: simple fix for problem

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 283613 [details] [diff] [review]
patch v1: simple fix for problem

File a bug for the FIXME, cite in the comment? Or are you just going to use this bug?

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: cites FIXME bug number in comment

(In reply to comment #3)
> (From update of attachment 283613 [details] [diff] [review])
> File a bug for the FIXME, cite in the comment? Or are you just going to use
> this bug?

In the interests of incremental improvement, let's check this in and then deal with specific icons for these two actions as a separate issue.  I have filed bug 398627 on getting specific icons.

Here's a version of the patch that is equivalent to the previous patch except that it cites the bug number for the FIXME bug in the comment.

Requesting approval to check in this simple, low-risk polish fix.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Checking in browser/components/preferences/applications.js;
/cvsroot/mozilla/browser/components/preferences/applications.js,v  <--  applications.js
new revision: 1.21; previous revision: 1.20
done