398597 - some recently checked in png not visible

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9a9pre) Gecko/2007100322 Minefield/3.0a9pre
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9a9pre) Gecko/2007100322 Minefield/3.0a9pre

At least with OS/2 not visible

Reproducible: Always

Steps to Reproduce:
1. http://mxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/mozapps/downloads/buttons.png (bug388517 https://bugzilla.mozilla.org/attachment.cgi?id=276206)
2. http://mxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/mozapps/plugins/pluginGeneric.png (bug391670,https://bugzilla.mozilla.org/attachment.cgi?id=281669)
3. http://mxr.mozilla.org/seamonkey/source/browser/themes/winstripe/browser/wrench.png (bug387740, https://bugzilla.mozilla.org/attachment.cgi?id=281355)



bug386443#c5 tells how the attributes in cvs have to be set for the pngs that they become visible for all OSes.

Comment 1

[Walter Meinl]

the same concern is about the respective pinstripe pngs (not an issue for OS/2 however) 

Comment 2

[Walter Meinl]

/mozilla/browser/themes/winstripe/browser/preferences/application.png and /mozilla/browser/themes/winstripe/browser/preferences/plugin.png checked in today with bug395141 (included in https://bugzilla.mozilla.org/attachment.cgi?id=282650) don't display as well

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I've marked these as binary files and forced a commit to make sure they get updated by LXR/MXR.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/themes/pinstripe/mozapps/downloads/buttons.png 	1.2
mozilla/browser/themes/pinstripe/browser/preferences/application.png 	1.2
mozilla/browser/themes/pinstripe/browser/preferences/plugin.png 	1.2
mozilla/toolkit/themes/pinstripe/mozapps/plugins/pluginGeneric.png 	1.2
mozilla/browser/themes/pinstripe/browser/wrench.png 	1.2
mozilla/toolkit/themes/winstripe/mozapps/downloads/buttons.png 	1.2
mozilla/toolkit/themes/winstripe/mozapps/plugins/pluginGeneric.png 	1.2
mozilla/browser/themes/winstripe/browser/wrench.png 	1.2
mozilla/browser/themes/winstripe/browser/preferences/application.png 	1.2
mozilla/browser/themes/winstripe/browser/preferences/plugin.png 	1.2 

Comment 5

[Peter Weilbacher]

By doing
   find browser toolkit -name Entries -exec grep -Hi png {} \; | grep -v '\-kb'
I found 25 more PNG files that were not checked in as binaries:

browser/app/mozicon128.png
browser/themes/pinstripe/browser/identity.png
browser/themes/pinstripe/browser/monitor_16-10.png
browser/themes/pinstripe/browser/places/folderDropArrow.png
browser/themes/pinstripe/browser/places/folderDropHoverArrow.png
browser/themes/pinstripe/browser/places/livemarkFolder.png
browser/themes/pinstripe/browser/places/livemarkFolderHover.png
browser/themes/pinstripe/browser/safebrowsing/close16x16.png
browser/themes/pinstripe/browser/safebrowsing/dim.png
browser/themes/pinstripe/browser/safebrowsing/tail.png
browser/themes/pinstripe/browser/safebrowsing/warning16x16.png
browser/themes/pinstripe/browser/safebrowsing/warning24x24.png
browser/themes/winstripe/browser/identity.png
browser/themes/winstripe/browser/monitor_16-10.png
browser/themes/winstripe/browser/safebrowsing/close16x16.png
browser/themes/winstripe/browser/safebrowsing/dim.png
browser/themes/winstripe/browser/safebrowsing/tail.png
browser/themes/winstripe/browser/safebrowsing/warning16x16.png
browser/themes/winstripe/browser/safebrowsing/warning24x24.png
toolkit/themes/pinstripe/global/icons/blacklist_favicon.png
toolkit/themes/pinstripe/global/icons/blacklist_large.png
toolkit/themes/pinstripe/global/icons/Error.png
toolkit/themes/pinstripe/mozapps/downloads/downloadIcon.png
toolkit/themes/winstripe/global/icons/blacklist_favicon.png
toolkit/themes/winstripe/global/icons/blacklist_large.png

Some of them have been in that state for quite a while but perhaps it would make sense to fix them. Gavin, would you do that?

Isn't there something that the admins can do to the CVS repository to make PNGs binary automatically so that this doesn't happen again?

Comment 6

[Peter Weilbacher]

Hmm, I looked it up and our CVS server has 
   *.png -k 'b'
   *.gif -k 'b'
   *.jpg -k 'b'
   *.jpeg -k 'b'
in CVSROOT/cvswrappers for this purpose. I can't look at that file in the Mozilla CVS.

By the same way I also found that

browser/themes/pinstripe/browser/Secure-background.gif
toolkit/components/passwordmgr/test/mlogosm.gif
toolkit/themes/pinstripe/global/scale/scale-tray-horiz.gif
toolkit/themes/pinstripe/global/scale/scale-tray-vert.gif
toolkit/themes/pinstripe/global/splitter/grip-hrz-after.gif
toolkit/themes/pinstripe/global/splitter/grip-hrz-before.gif
toolkit/themes/pinstripe/global/splitter/grip-vrt-after.gif
toolkit/themes/pinstripe/global/splitter/grip-vrt-before.gif
toolkit/themes/winstripe/global/scale/scale-tray-horiz.gif
toolkit/themes/winstripe/global/scale/scale-tray-vert.gif
toolkit/themes/winstripe/global/splitter/grip-hrz-after.gif
toolkit/themes/winstripe/global/splitter/grip-hrz-before.gif
toolkit/themes/winstripe/global/splitter/grip-vrt-after.gif
toolkit/themes/winstripe/global/splitter/grip-vrt-before.gif

have the same problem of not being marked binary (although some of them display fine on OS/2, so I guess they were checked in from Windows). I didn't find any JPEGs in the tree with this problem, though.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #6)
> Hmm, I looked it up and our CVS server has 
>    *.png -k 'b'
>    *.gif -k 'b'
>    *.jpg -k 'b'
>    *.jpeg -k 'b'
> in CVSROOT/cvswrappers for this purpose. I can't look at that file in the
> Mozilla CVS.

Could you file a mozilla.org::CVS Administration bug to investigate adding that to our repository?

Comment 8

[Walter Meinl]

(In reply to comment #7)
> Could you file a mozilla.org::CVS Administration bug to investigate adding that
> to our repository?
> 
Though bug398690 is fixed now and hopefully new graphics are handled correctly, the older ones Peter posted in comment#5 and comment#6 are probably not yet. Specifically, I miss to see the nice policeman when I drop down the Larry field. It's 
browser/themes/winstripe/browser/identity.png

Comment 9

[Peter Weilbacher]

OK, I now marked as binary in CVS all files from comment 5 and comment 6. After a cvs update I can now see all of them in PMView on OS/2, too.