398676 - Add support for tel: protocol

Status: RESOLVED FIXED

(Toolkit Graveyard :: Microformats, defect)

Description

[Mike Kaply [:mkaply]]

Need to add support for tel: protocol

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Support for tel/modem/fax protocols

This patch adds support for the mentioned protocols.

This required a small change to how implied properties work. I wasn't honoring the datatype of the implied property.

Comment 2

[Benjamin Smedberg]

Are you following RFC 3966 or 2806, or some bastardized combination of the two?

Comment 3

[Mike Kaply [:mkaply]]

Probably a bastardization. 

from

http://microformats.org/wiki/hcard-parsing

For the "tel" property in particular, when the element is:

    * <a href="tel:..."> OR <area href="tel:..."> : parse the value of the 'href' attribute, omitting the "tel:" prefix and any "?" query suffix (if present), in the attribute. For details on the "tel:" URL scheme, see RFC 2806. 


Basically I'm just pulling off the tel:/modem:/fax: protocol and using the rest as the phone number with no parsing.

Comment 4

[Mike Kaply [:mkaply]]

Fixed in Operator. Moving to Microformats core.

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 291673 [details] [diff] [review]
Support for tel/modem/fax protocols

This patch isn't doing anything really technically. Just if there is a protocol for a telephone number, strip it and use the rest as a phone number.

Comment 6

[Robert Sayre]

needs tests

Comment 7

[Mike Kaply [:mkaply]]

Sorry, should have said that. Tests are already in, but commented out in test_Microformats_hcard.html

http://lxr.mozilla.org/seamonkey/source/toolkit/components/microformats/tests/test_Microformats_hCard.html?raw=1

Comment 8

[Robert Sayre]

Oh good. Attach a new patch with those and I'll r+.

Comment 9

[Mike Kaply [:mkaply]]

Attachment: Fix with tests

Yeah with tests is much better. Especially since those tests didn't work at first when I uncommented them.

Comment 10

[Mike Kaply [:mkaply]]

checked in.