398677 - browser.download.manager.addToRecentDocs is not set by default

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Phil Ringnalda (:philor)]

+++ This bug was initially created as a clone of Bug #398174 +++

Though unlike bug 398174's description, I'll explain that the download manager code defaults to true if it doesn't find the pref, that it's Windows-only, and that I'm not entirely sure whether or not our default value for it should be true - personally, I don't think of saved attachments as documents I've recently opened unless... I've recently opened them (which, perversely, seems not to add them to the list, while saving does).

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Meh. If we add a default set to false, nobody will ever look for it, to know whether or not they want it; if we don't add a default, then it will be harder for people who really hate it to turn it off; if we add a default set to true, at least we'll find out how many people hate it, while still being able to tell them how to work around it.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 285642 [details] [diff] [review]
Fix v.1

Sure, r=mkmelin+mozilla
I imagine it could be useful to some people.

Comment 3

[Phil Ringnalda (:philor)]

mail/app/profile/all-thunderbird.js 1.99

Comment 4

[Joe Sabash [:JoeS1]]

While I'm perfectly willing to test this in trunk TB, it would be nice to know just what I am testing. I assume it adds saved attachment to recent docs. A feature that I have never used, depended upon, or have found particulary useful in any way.
I'll test the checkin, but please be more specific on what to test.
(Might be a little grouchy tonight since my Steelers lost in the last 3 seconds)

Comment 5

[Phil Ringnalda (:philor)]

You don't need to test it, just experience it. Toolkit's download manager, which we use for saving attachments and "save link as", is adding everything you run through it to Windows' recent documents list unless we tell it not to (and has been for quite a while, without anyone noticing it as far as I know): if you never use that list, then you have no need to form an opinion about it. People who do use it need to form an opinion about whether or not it's helpful to have saved attachments push actual opened documents out of the list, the same way that Firefox users who do use it will need to form an opinion about whether it's useful to have downloaded-but-not-opened files push out opened documents.

Comment 6

[Joe Sabash [:JoeS1]]

Thanks for the explanation Phil.
Personally, I don't want any software that I run doing things that I don't know about. The entry in recent docs could only get in the way. Disabled by pref. thx.
Incidentaly, for Newsgroups it seems a recent docs entry is not made  when saving inline images, which must be re-downloaded (even though you are viewing them) 
  I asked about this re-downloading a long time ago, and I believe the answer was something like "we really don't know exactly where the image is, could be memory or system cache" So we just re-download them again.
  I guess the problem is minimal with high speed internet the norm these days, but I still know a few dialup users who find it very annoying.

Comment 7

[Joe Sabash [:JoeS1]]

Opinion now well formed. As for the practical application
Setting browser.download.manager.addToRecentDocs to false seems to have no effect

Comment 8

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #7)
> Setting browser.download.manager.addToRecentDocs to false seems to have no
> effect

See bug 310071 comment 6?