Remove default suffix rules from rules.mk, and some fixes to help automated rewriting

RESOLVED FIXED

Status

RESOLVED FIXED
11 years ago
8 months ago

People

(Reporter: benjamin, Assigned: benjamin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 283713 [details] [diff] [review]
rules.mk changes for automatic rewriting, rev. 1

We can help the automated rewriting effort by changing a little bit of rules.mk:

1) Disable all the default rules all the time... this should improve build speed (perhaps significantly!) as well as prevent some of the default %.o: %.s from ever being applied

2) Disable the assembly-source rule unless a makefile explicitly specifies assembly files. This will help because automated rewriting leaves intermediate .ii and .s files around and rules.mk gets confused about what it's supposed to be building.

3) Add the intermediate targets to the garbage. This will remove all the intermediate .ii and .s files in "make clean" so that you can do full rebuilds of specific directories

I really want this for moz2, but I don't see any reason it can't land in CVS for 1.9
Attachment #283713 - Flags: review?(ted.mielczarek)
Attachment #283713 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 1

11 years ago
Comment on attachment 283713 [details] [diff] [review]
rules.mk changes for automatic rewriting, rev. 1

Again, this is very low-risk assuming the tboxes don't turn red.
Attachment #283713 - Flags: approval1.9?

Updated

11 years ago
Attachment #283713 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 2

11 years ago
Fixed on CVS trunk for 1.9
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Depends on: 402824

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.