Closed
Bug 398730
Opened 17 years ago
Closed 17 years ago
Remove default suffix rules from rules.mk, and some fixes to help automated rewriting
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
1.32 KB,
patch
|
ted
:
review+
sayrer
:
approval1.9+
|
Details | Diff | Splinter Review |
We can help the automated rewriting effort by changing a little bit of rules.mk:
1) Disable all the default rules all the time... this should improve build speed (perhaps significantly!) as well as prevent some of the default %.o: %.s from ever being applied
2) Disable the assembly-source rule unless a makefile explicitly specifies assembly files. This will help because automated rewriting leaves intermediate .ii and .s files around and rules.mk gets confused about what it's supposed to be building.
3) Add the intermediate targets to the garbage. This will remove all the intermediate .ii and .s files in "make clean" so that you can do full rebuilds of specific directories
I really want this for moz2, but I don't see any reason it can't land in CVS for 1.9
Attachment #283713 -
Flags: review?(ted.mielczarek)
Updated•17 years ago
|
Attachment #283713 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 1•17 years ago
|
||
Comment on attachment 283713 [details] [diff] [review]
rules.mk changes for automatic rewriting, rev. 1
Again, this is very low-risk assuming the tboxes don't turn red.
Attachment #283713 -
Flags: approval1.9?
Updated•17 years ago
|
Attachment #283713 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 2•17 years ago
|
||
Fixed on CVS trunk for 1.9
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•