User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007100605 Minefield/3.0a9pre Build Identifier: Aboutbloat.cpp should be compiles if trace-refcnt logging is ON. I has a patch ready for it. Reproducible: Always Steps to Reproduce: 1. 2. 3.
Created attachment 283887 [details] [diff] [review] patch v1
Assignee: nobody → xfsunoles
Status: NEW → ASSIGNED
Created attachment 283888 [details] [diff] [review] Patch v1.1
Attachment #283887 - Attachment is obsolete: true
about:bloat doesn't do anything in builds without trace-refcnt enabled, so if it's adding to release build footprint, I think we should fix that.
The concept sounds good, except you also need to ifdef nsNetModule.cpp.
Created attachment 283943 [details] [diff] [review] Patch v2.0
Created attachment 284095 [details] [diff] [review] Patch v2.1
Summary: Aboutbloat should be under trace-refcnt logging → about:bloat should be under trace-refcnt logging
Summary: about:bloat should be under trace-refcnt logging → about:bloat should only be built if trace-refcnt logging is built
Checking in netwerk/build/nsNetModule.cpp; /cvsroot/mozilla/netwerk/build/nsNetModule.cpp,v <-- nsNetModule.cpp new revision: 1.144; previous revision: 1.143 done Checking in netwerk/protocol/about/src/Makefile.in; /cvsroot/mozilla/netwerk/protocol/about/src/Makefile.in,v <-- Makefile.in new revision: 1.35; previous revision: 1.34 done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
Created attachment 284717 [details] [diff] [review] bustage fix Had to check-in a bustage fix for this. This seems to work, but I wasn't completely sure on where I should place the checks and such.
You need to log in before you can comment on or make changes to this bug.