about:bloat should only be built if trace-refcnt logging is built

RESOLVED FIXED in mozilla1.9beta1

Status

()

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: xfsunoles, Assigned: xfsunoles)

Tracking

({memory-footprint})

Trunk
mozilla1.9beta1
memory-footprint
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

11 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007100605 Minefield/3.0a9pre
Build Identifier: 

Aboutbloat.cpp should be compiles if trace-refcnt logging is ON. I has a patch ready for it. 

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
(Assignee)

Comment 1

11 years ago
Created attachment 283887 [details] [diff] [review]
patch v1
Assignee: nobody → xfsunoles
Status: NEW → ASSIGNED
(Assignee)

Comment 2

11 years ago
Created attachment 283888 [details] [diff] [review]
Patch v1.1
Attachment #283887 - Attachment is obsolete: true

Comment 3

11 years ago
about:bloat doesn't do anything in builds without trace-refcnt enabled, so if it's adding to release build footprint, I think we should fix that.
Keywords: footprint
(Assignee)

Updated

11 years ago
Attachment #283888 - Flags: superreview?(cbiesinger)
Attachment #283888 - Flags: review?(cbiesinger)
(Assignee)

Comment 5

11 years ago
Created attachment 283943 [details] [diff] [review]
Patch v2.0
Attachment #283888 - Attachment is obsolete: true
Attachment #283888 - Flags: superreview?(cbiesinger)
Attachment #283888 - Flags: review?(cbiesinger)
(Assignee)

Updated

11 years ago
Attachment #283943 - Flags: superreview?(cbiesinger)
Attachment #283943 - Flags: review?(cbiesinger)
OS: Windows XP → All
Hardware: PC → All
(Assignee)

Comment 6

11 years ago
Created attachment 284095 [details] [diff] [review]
Patch v2.1
Attachment #283943 - Attachment is obsolete: true
Attachment #284095 - Flags: superreview?(bzbarsky)
Attachment #284095 - Flags: review?(bzbarsky)
Attachment #283943 - Flags: superreview?(cbiesinger)
Attachment #283943 - Flags: review?(cbiesinger)
Summary: Aboutbloat should be under trace-refcnt logging → about:bloat should be under trace-refcnt logging
Attachment #284095 - Flags: superreview?(bzbarsky)
Attachment #284095 - Flags: superreview+
Attachment #284095 - Flags: review?(bzbarsky)
Attachment #284095 - Flags: review+
(Assignee)

Updated

11 years ago
Attachment #284095 - Flags: approval1.9?

Updated

11 years ago
Summary: about:bloat should be under trace-refcnt logging → about:bloat should only be built if trace-refcnt logging is built

Updated

11 years ago
Attachment #284095 - Flags: approval1.9? → approval1.9+
(Assignee)

Updated

11 years ago
Keywords: checkin-needed
Checking in netwerk/build/nsNetModule.cpp;
/cvsroot/mozilla/netwerk/build/nsNetModule.cpp,v  <--  nsNetModule.cpp
new revision: 1.144; previous revision: 1.143
done
Checking in netwerk/protocol/about/src/Makefile.in;
/cvsroot/mozilla/netwerk/protocol/about/src/Makefile.in,v  <--  Makefile.in
new revision: 1.35; previous revision: 1.34
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
Created attachment 284717 [details] [diff] [review]
bustage fix

Had to check-in a bustage fix for this. This seems to work, but I wasn't completely sure on where I should place the checks and such.
You need to log in before you can comment on or make changes to this bug.