Closed
Bug 398895
Opened 18 years ago
Closed 18 years ago
about:bloat should only be built if trace-refcnt logging is built
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla1.9beta1
People
(Reporter: xfsunoles, Assigned: xfsunoles)
Details
(Keywords: memory-footprint)
Attachments
(2 files, 3 obsolete files)
|
2.52 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
sayrer
:
approval1.9+
|
Details | Diff | Splinter Review |
|
1.79 KB,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007100605 Minefield/3.0a9pre
Build Identifier:
Aboutbloat.cpp should be compiles if trace-refcnt logging is ON. I has a patch ready for it.
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
|
Assignee | |
Comment 1•18 years ago
|
||
Assignee: nobody → xfsunoles
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•18 years ago
|
||
Attachment #283887 -
Attachment is obsolete: true
|
||
Comment 3•18 years ago
|
||
about:bloat doesn't do anything in builds without trace-refcnt enabled, so if it's adding to release build footprint, I think we should fix that.
Keywords: footprint
|
|
Assignee | |
Updated•18 years ago
|
Attachment #283888 -
Flags: superreview?(cbiesinger)
Attachment #283888 -
Flags: review?(cbiesinger)
The concept sounds good, except you also need to ifdef nsNetModule.cpp.
|
|
Assignee | |
Comment 5•18 years ago
|
||
Attachment #283888 -
Attachment is obsolete: true
Attachment #283888 -
Flags: superreview?(cbiesinger)
Attachment #283888 -
Flags: review?(cbiesinger)
|
|
Assignee | |
Updated•18 years ago
|
Attachment #283943 -
Flags: superreview?(cbiesinger)
Attachment #283943 -
Flags: review?(cbiesinger)
|
||
Updated•18 years ago
|
OS: Windows XP → All
Hardware: PC → All
|
|
Assignee | |
Comment 6•18 years ago
|
||
Attachment #283943 -
Attachment is obsolete: true
Attachment #284095 -
Flags: superreview?(bzbarsky)
Attachment #284095 -
Flags: review?(bzbarsky)
Attachment #283943 -
Flags: superreview?(cbiesinger)
Attachment #283943 -
Flags: review?(cbiesinger)
|
|
||
Updated•18 years ago
|
Summary: Aboutbloat should be under trace-refcnt logging → about:bloat should be under trace-refcnt logging
|
|
||
Updated•18 years ago
|
Attachment #284095 -
Flags: superreview?(bzbarsky)
Attachment #284095 -
Flags: superreview+
Attachment #284095 -
Flags: review?(bzbarsky)
Attachment #284095 -
Flags: review+
|
|
Assignee | |
Updated•18 years ago
|
Attachment #284095 -
Flags: approval1.9?
|
|
||
Updated•18 years ago
|
Summary: about:bloat should be under trace-refcnt logging → about:bloat should only be built if trace-refcnt logging is built
|
||
Updated•18 years ago
|
Attachment #284095 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Updated•18 years ago
|
Keywords: checkin-needed
|
|
||
Comment 7•18 years ago
|
||
Checking in netwerk/build/nsNetModule.cpp;
/cvsroot/mozilla/netwerk/build/nsNetModule.cpp,v <-- nsNetModule.cpp
new revision: 1.144; previous revision: 1.143
done
Checking in netwerk/protocol/about/src/Makefile.in;
/cvsroot/mozilla/netwerk/protocol/about/src/Makefile.in,v <-- Makefile.in
new revision: 1.35; previous revision: 1.34
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
|
|
||
Comment 8•18 years ago
|
||
Had to check-in a bustage fix for this. This seems to work, but I wasn't completely sure on where I should place the checks and such.
You need to log in
before you can comment on or make changes to this bug.
Description
•