398986 - Incorrect SQL query when moving bugs to another product

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

Attachment: patch, v1

'?' x 5 means '?????', which is not what we want as join()'ing this string has no effect.

('?') x 5 means ('?','?','?','?','?'), which is the expected array as join()'ing this will give '?,?,?,?,?'.

This is a regression due to bug 373689. Note that we could as well write:
  join(', ', @idlist)
as I did in the original implementation of this code.

Comment 1

[Frédéric Buclin]

FYI, running PostgreSQL displays a blank page instead of the intermediate page.

Comment 2

[Max Kanat-Alexander]

Comment on attachment 283987 [details] [diff] [review]
patch, v1

Hrm, okay. The docs said that in list context the "x" operator returns a list. Ah well.

Comment 3

[Max Kanat-Alexander]

By the way, one reason that we do ('?') x @idlist instead of "join(',', @idlist)" is that the query analyzer can cache this query, and it can't cache the query with numbers in it. Also, I think it's always better to use placeholders where it's reasonable to use them.

Comment 4

[Frédéric Buclin]

Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.208; previous revision: 1.207
done