Remove the 'cookiedomain' parameter

RESOLVED FIXED

Status

()

Bugzilla
Administration
--
enhancement
RESOLVED FIXED
10 years ago
8 months ago

People

(Reporter: Frédéric Buclin, Assigned: Simon Green)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Per our discussions at our last 2 Bugzilla meetings, this param should go away.

Comment 1

10 years ago
If you remove this parameter, it's no longer possible to drive multiple Bugzilla databases instances with one bugzilla installation.

Bugzilla gets confused with the login.

Comment 2

10 years ago
Solution is to have multiple Bugzilla installations.
That would be (in 2.x) 19M of hard drive space per Bugzilla installation? 

I create duplicate installs for, for instance, my test installations, already.

Comment 3

10 years ago
(In reply to comment #1)
> If you remove this parameter, it's no longer possible to drive multiple
> Bugzilla databases instances with one bugzilla installation.
> 
> Bugzilla gets confused with the login.

  This is an interesting point. I think if the PROJECT variable is set, we should perhaps pass the cookiedomain that was used in the Host header.

Comment 4

10 years ago
> I create duplicate installs for, for instance, my test installations, already.

Sure, it is possible to install multiple Bugzilla installations. But this just generates more work for updates and patches. I think that's the reason why the PROJECT variable was introduced.

> This is an interesting point. I think if the PROJECT variable is set, we
> should perhaps pass the cookiedomain that was used in the Host header.

Just append the standard-cookie-domain-Path with the PROJECT-Variable. That's what I do manually now.


Comment 5

10 years ago
> Solution is to have multiple Bugzilla installations.

Even if you have multiple Bugzilla installations the problem persists: The cookie name for for each installation on the same server is identical.
(Reporter)

Comment 6

10 years ago
(In reply to comment #5)
> Even if you have multiple Bugzilla installations the problem persists: The
> cookie name for for each installation on the same server is identical.
> 

But the cookie path is different, see the cookiepath parameter, allowing you to have as many Bugzilla installations on the same server without any interference. landfill, our test server, has tens of Bugzilla installations, and there is no interaction between them at all, including cookies.

Comment 7

10 years ago
(In reply to comment #6)
> But the cookie path is different,

  Unless they're all at different virtual hosts.
(Assignee)

Comment 8

2 years ago
I'll do this once bug 399067 has been approved, since the patch for the two changes interferes with each other
Assignee: administration → bugzilla
Status: NEW → ASSIGNED
Depends on: 399067

Comment 9

2 years ago
Can someone state definitively whether this change, and the related change to cookiepath, will effectively disable the multi-site PROJECT feature? I've been following the discussion but that point seems unclear.
(Reporter)

Comment 10

2 years ago
The PROJECT feature will still work.
(Assignee)

Comment 11

2 years ago
Created attachment 8642023 [details] [diff] [review]
bug399066-v1.patch
Attachment #8642023 - Flags: review?(dylan)
Comment on attachment 8642023 [details] [diff] [review]
bug399066-v1.patch

r=dylan
Attachment #8642023 - Flags: review?(dylan) → review+
(Assignee)

Comment 13

8 months ago
To github.com:bugzilla/bugzilla.git
   a460196..c67b3b3  master -> master
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.