399066 - Remove the 'cookiedomain' parameter

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Frédéric Buclin]

Per our discussions at our last 2 Bugzilla meetings, this param should go away.

Comment 1

[Matthias Ludwig]

If you remove this parameter, it's no longer possible to drive multiple Bugzilla databases instances with one bugzilla installation.

Bugzilla gets confused with the login.

Comment 2

[Rob Echlin]

Solution is to have multiple Bugzilla installations.
That would be (in 2.x) 19M of hard drive space per Bugzilla installation? 

I create duplicate installs for, for instance, my test installations, already.

Comment 3

[Max Kanat-Alexander]

(In reply to comment #1)
> If you remove this parameter, it's no longer possible to drive multiple
> Bugzilla databases instances with one bugzilla installation.
> 
> Bugzilla gets confused with the login.

  This is an interesting point. I think if the PROJECT variable is set, we should perhaps pass the cookiedomain that was used in the Host header.

Comment 4

[Matthias Ludwig]

> I create duplicate installs for, for instance, my test installations, already.

Sure, it is possible to install multiple Bugzilla installations. But this just generates more work for updates and patches. I think that's the reason why the PROJECT variable was introduced.

> This is an interesting point. I think if the PROJECT variable is set, we
> should perhaps pass the cookiedomain that was used in the Host header.

Just append the standard-cookie-domain-Path with the PROJECT-Variable. That's what I do manually now.

Comment 5

[Matthias Ludwig]

> Solution is to have multiple Bugzilla installations.

Even if you have multiple Bugzilla installations the problem persists: The cookie name for for each installation on the same server is identical.

Comment 6

[Frédéric Buclin]

(In reply to comment #5)
> Even if you have multiple Bugzilla installations the problem persists: The
> cookie name for for each installation on the same server is identical.
> 

But the cookie path is different, see the cookiepath parameter, allowing you to have as many Bugzilla installations on the same server without any interference. landfill, our test server, has tens of Bugzilla installations, and there is no interaction between them at all, including cookies.

Comment 7

[Max Kanat-Alexander]

(In reply to comment #6)
> But the cookie path is different,

  Unless they're all at different virtual hosts.

Comment 8

[Simon Green]

I'll do this once bug 399067 has been approved, since the patch for the two changes interferes with each other

Comment 9

[Jeff Rivett]

Can someone state definitively whether this change, and the related change to cookiepath, will effectively disable the multi-site PROJECT feature? I've been following the discussion but that point seems unclear.

Comment 10

[Frédéric Buclin]

The PROJECT feature will still work.

Comment 11

[Simon Green]

Attachment: bug399066-v1.patch

Comment 12

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8642023 [details] [diff] [review]
bug399066-v1.patch

r=dylan

Comment 13

[Simon Green]

To github.com:bugzilla/bugzilla.git
   a460196..c67b3b3  master -> master