399074 - Remove the 'maxpatchsize' parameter

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Frédéric Buclin]

Per our discussions at our last 2 Bugzilla meetings, this param should go away. It should be the same as 'maxattachmentsize'.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Max Kanat-Alexander]

Comment on attachment 352107 [details] [diff] [review]
patch, v1

Looks good to me!

Comment 3

[Frédéric Buclin]

Checking in Bugzilla/Attachment.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Attachment.pm,v  <--  Attachment.pm
new revision: 1.60; previous revision: 1.59
done
Checking in Bugzilla/Config/Attachment.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/Attachment.pm,v  <--  Attachment.pm
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/admin/params/attachment.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/params/attachment.html.tmpl,v  <--  attachment.html.tmpl
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <-- user-error.html.tmpl
new revision: 1.267; previous revision: 1.266
done

Comment 4

[timeless]

this patch is incomplete. you should have migrated the larger of the two sizes as part of the migration. otherwise installations like bmo will be left high and dry.

Comment 5

[Frédéric Buclin]

(In reply to comment #4)
> this patch is incomplete. you should have migrated the larger of the two sizes
> as part of the migration. otherwise installations like bmo will be left high
> and dry.

This is not needed. You are free to edit this param after the upgrade.

Comment 6

[Max Kanat-Alexander]

Added to the release notes for Bugzilla 3.4 in bug 494037.

Comment 7

[Philip Chimento [:ptomato]]

Attachment: Test that structured clone of ArrayBuffer with custom free function fails

Comment 8

[Philip Chimento [:ptomato]]

Sorry, mess-up with 'hg bzexport'.