399080 - Remove the 'usebugaliases' parameter

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Frédéric Buclin]

Per our discussions at our last 2 Bugzilla meetings, this param should go away. It should always be 1.

Comment 1

[Matt Selsky [:selsky]]

Attachment: Remove the usebugaliases parameter and always enable aliases, v1

Comment 2

[Frédéric Buclin]

Comment on attachment 564102 [details] [diff] [review]
Remove the usebugaliases parameter and always enable aliases, v1

>=== modified file 'Bugzilla/WebService/Bug.pm'

You must also update the POD in this file and remove the sentence with "Note that it's possible for aliases to be disabled in Bugzilla" as well as update the text for Error 100: "(a) the Bugzilla you're querying doesn't support aliases" is no longer true. There are also some other comments which need to be fixed in the POD of this file. I will let you find and fix them. :)

Also make sure that there is no other references to "alias" in the documentation of our API. The documentation in docs/en/xml/ is fine, though.


I didn't check nor test all places affected by your patch, but everything else looks good so far. :)

Comment 3

[Matt Selsky [:selsky]]

Attachment: Remove the usebugaliases parameter and always enable aliases, v2

Bugzilla::WebService::Bug POD updated.

Comment 4

[Frédéric Buclin]

Comment on attachment 577200 [details] [diff] [review]
Remove the usebugaliases parameter and always enable aliases, v2

>=== modified file 'template/en/default/pages/quicksearch.html.tmpl'

>-    [%+ IF Param('usebugaliases') %][% field_descs.alias FILTER html %],[% END %]
>+    [% field_descs.alias FILTER html %],

You must write [%+ to add a whitespace before Alias. Please fix that on checkin.


Everything else looks good. Thanks for the patch! :) r=LpSolit

Comment 5

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified colchange.cgi
modified process_bug.cgi
modified Bugzilla/Bug.pm
modified Bugzilla/Config/BugFields.pm
modified Bugzilla/WebService/Bug.pm
modified template/en/default/admin/params/bugfields.html.tmpl
modified template/en/default/bug/edit.html.tmpl
modified template/en/default/bug/show-multiple.html.tmpl
modified template/en/default/bug/create/create.html.tmpl
modified template/en/default/global/user-error.html.tmpl
modified template/en/default/pages/fields.html.tmpl
modified template/en/default/pages/quicksearch.html.tmpl
modified xt/lib/Bugzilla/Test/Search.pm
Committed revision 8049.

Comment 6

[Frédéric Buclin]

Added to relnotes for 4.4.