399199 - jsfile.c fails to compile

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Watkins]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-gb) AppleWebKit/523.10.1 (KHTML, like Gecko) Version/3.0.4 Safari/523.10
Build Identifier: Latest CVS source

jsfile.c: In function ‘file_toURL’:
jsfile.c:2062: error: too many arguments to function ‘js_NewString’



Reproducible: Always

Steps to Reproduce:
1. Add the following lines to Makefile.ref near the top:
    #BEGIN: JW
    JS_HAS_FILE_OBJECT= 1
    JS_THREADSAFE=1
    DIST=../../target/dist
    #END: JW

2. Make clean (make -f Makefile.ref clean)
3. Make


Actual Results:  
It didn't compile.

Expected Results:  
Compiling would have been nice.

I'll post a patch as soon as this bug is filed.

Comment 1

[Jeff Watkins]

Attachment: cvs diff of changes to jsfile.c to make it compile

I couldn't figure out how to make CVS spit out a patch file, so I used diff instead.

Comment 2

[Brian Crowder]

Use |cvs diff -up8|

Comment 3

[Jeff Watkins]

Attachment: Proper CVS patch for jsfile.c

Thanks, I'm more a subversion guy...

Comment 4

[Brian Crowder]

Comment on attachment 284179 [details] [diff] [review]
Proper CVS patch for jsfile.c

Trivial patch.

Comment 5

[Igor Bukanov]

Comment on attachment 284179 [details] [diff] [review]
Proper CVS patch for jsfile.c

No need for an approval as the file is not a part of browser builds.

Comment 6

[Brian Crowder]

jsfile.c: 3.49