If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Form manager shouldn't cache Login Manager service at startup.

RESOLVED FIXED

Status

()

Toolkit
Form Manager
--
minor
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Dolske, Assigned: Dolske)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 284249 [details] [diff] [review]
Patch for review, v.1

From bug 394603:

When looking at how pwmgr is started up, I noticed that we're actually starting pwmgr indirectly as a result of satchel... browser.xml's attachFormFill() causes satchel to be created during startup, which was caching the pwmgr service and accidently creating it.

This isn't really a problem, but with the performance work going on (and 394603), this helps account for startup costs in the right places.

This patch defers the caching of mLoginManager. Login manager is the only thing calling MarkAsLoginManagerField, so we know the service is already running at that point. There's no need for the form manager to use the service until after a field has been marked this way, so the do_GetService() call is moved there.
Attachment #284249 - Flags: review?(gavin.sharp)
Attachment #284249 - Flags: review?(gavin.sharp) → review+
(Assignee)

Updated

10 years ago
Attachment #284249 - Flags: approval1.9?

Updated

10 years ago
Attachment #284249 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 1

10 years ago
Checking in toolkit/components/satchel/src/nsFormFillController.cpp;
/cvsroot/mozilla/toolkit/components/satchel/src/nsFormFillController.cpp,v  <--  nsFormFillController.cpp
new revision: 1.94; previous revision: 1.93
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.