399259 - Form manager shouldn't cache Login Manager service at startup.

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Patch for review, v.1

From bug 394603:

When looking at how pwmgr is started up, I noticed that we're actually starting pwmgr indirectly as a result of satchel... browser.xml's attachFormFill() causes satchel to be created during startup, which was caching the pwmgr service and accidently creating it.

This isn't really a problem, but with the performance work going on (and 394603), this helps account for startup costs in the right places.

This patch defers the caching of mLoginManager. Login manager is the only thing calling MarkAsLoginManagerField, so we know the service is already running at that point. There's no need for the form manager to use the service until after a field has been marked this way, so the do_GetService() call is moved there.

Comment 1

[Justin Dolske [:Dolske]]

Checking in toolkit/components/satchel/src/nsFormFillController.cpp;
/cvsroot/mozilla/toolkit/components/satchel/src/nsFormFillController.cpp,v  <--  nsFormFillController.cpp
new revision: 1.94; previous revision: 1.93
done