399262 - "ASSERTION: NS_BLOCK_HAS_FIRST_LETTER_STYLE state out of sync" with select::first-letter

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, I get this assertion in current debug build with it:
###!!! ASSERTION: NS_BLOCK_HAS_FIRST_LETTER_STYLE state out of sync: 'haveFirstL
etterStyle == ((mState & NS_BLOCK_HAS_FIRST_LETTER_STYLE) != 0)', file c:/mozill
a/mozilla/layout/generic/nsBlockFrame.cpp, line 6282

Comment 1

[Jesse Ruderman]

Still happens on trunk (Mac).

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Also happens with button::first-letter; layout/reftests/bugs/496032-1 (or reference)

Comment 3

[Mats Palmgren (inactive)]

Attachment: part 1

The assertion is a false positive.  We need to check for a -moz-button-content
pseudo in the if-statement to avoid it, since buttons are allowed to have
::first-letter.

https://tbpl.mozilla.org/?tree=Try&rev=2b0434b60791
https://tbpl.mozilla.org/?tree=Try&rev=7ee9c4244d03

Comment 4

[Mats Palmgren (inactive)]

Attachment: part 2

This part is to avoid asserting for <select> which we don't actually
support ::first-letter on.

https://tbpl.mozilla.org/?tree=Try&rev=b257de66ee87

Comment 5

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/98b193cac44f
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c1d71ef1284

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/98b193cac44f
https://hg.mozilla.org/mozilla-central/rev/3c1d71ef1284