Closed Bug 399262 Opened 13 years ago Closed 6 years ago

"ASSERTION: NS_BLOCK_HAS_FIRST_LETTER_STYLE state out of sync" with select::first-letter

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: martijn.martijn, Assigned: mats)

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

Attached file testcase
See testcase, I get this assertion in current debug build with it:
###!!! ASSERTION: NS_BLOCK_HAS_FIRST_LETTER_STYLE state out of sync: 'haveFirstL
etterStyle == ((mState & NS_BLOCK_HAS_FIRST_LETTER_STYLE) != 0)', file c:/mozill
a/mozilla/layout/generic/nsBlockFrame.cpp, line 6282
Summary: ASSERTION: NS_BLOCK_HAS_FIRST_LETTER_STYLE state out of sync with select::first-letter → "ASSERTION: NS_BLOCK_HAS_FIRST_LETTER_STYLE state out of sync" with select::first-letter
Still happens on trunk (Mac).
OS: Windows XP → All
Hardware: x86 → All
Also happens with button::first-letter; layout/reftests/bugs/496032-1 (or reference)
Attached patch part 1Splinter Review
The assertion is a false positive.  We need to check for a -moz-button-content
pseudo in the if-statement to avoid it, since buttons are allowed to have
::first-letter.

https://tbpl.mozilla.org/?tree=Try&rev=2b0434b60791
https://tbpl.mozilla.org/?tree=Try&rev=7ee9c4244d03
Assignee: nobody → mats
Attachment #8512693 - Flags: review?(roc)
Attached patch part 2Splinter Review
This part is to avoid asserting for <select> which we don't actually
support ::first-letter on.

https://tbpl.mozilla.org/?tree=Try&rev=b257de66ee87
Attachment #8525692 - Flags: review?(roc)
Attachment #8512693 - Attachment description: fix → part 1
You need to log in before you can comment on or make changes to this bug.