Closed Bug 399265 Opened 17 years ago Closed 17 years ago

Use the favicon service's hash table instead of cache to store failed favicons

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 beta1

People

(Reporter: rflint, Assigned: rflint)

References

Details

(Keywords: perf)

Attachments

(1 file)

Attached patch PatchSplinter Review
Currently we're hitting the cache every page load to check whether we want to load the favicon and then if we fail, we hit the cache again twice (once for the tab icon and again for the url bar) to mark that favicon as missing for the next load. At the same time we're registering the page's favicon with the favicon service which automatically does the above for us with a nice speedy hash table instead.

This patch should help Tp on most pages and will be most beneficial for pages with no favicon (even more so in cases where those pages are served over SSL - since our attempts to cache those fail by default).
Attachment #284257 - Flags: review?(mconnor)
Blocks: 397945
Comment on attachment 284257 [details] [diff] [review]
Patch

r=me, let's get this in tonight and get some testing on it?
Attachment #284257 - Flags: review?(mconnor)
Attachment #284257 - Flags: review+
Attachment #284257 - Flags: approval1.9+
mozilla/browser/base/content/browser.js     1.865
mozilla/browser/base/content/browser.xul    1.382
mozilla/browser/base/content/tabbrowser.xml 1.246
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Component: General → Tabbed Browser
QA Contact: general → tabbed.browser
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M9
You need to log in before you can comment on or make changes to this bug.