399278 - New Mail Notification PopUp shows BASE64 (Content-Transfer-Encoding treated as case sensitive)

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Alexander Skwar]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de; rv:1.8.1.7) Gecko/20070920 Firefox/2.0.0.7
Build Identifier: Version 2.0.0.6 (20070802)

In the New Mail Notification popup, the body of base64 encoded mails isn't decoded. Because of that, only some unreadable gibberish is shown.

Reproducible: Always

Steps to Reproduce:
1. Receive a mail with Content-Transfer-Encoding: BASE64

Actual Results:  
The first few words of the body is supposed to be shown. Instead, I see stuff like "MDkgT2N0b2JlciAyMDA3IC0gMDc6NTk6MjAg". That's because the mail is base64 encoded.

Expected Results:  
The body should be decoded before the popup is shown, so that legible text is shown.

I'll attach a screenshot showing what I mean. In this screenshot, you'll see that I received a mail from http://trashmail.net/. To verify the bug, you might want to use that service as well.

Comment 1

[Alexander Skwar]

Attachment: Screenshot of New Mail Notification popup

Comment 2

[Magnus Melin [:mkmelin]]

Can you attach a sample mail showing the symptoms? (Save as .eml)

Comment 3

[Alexander Skwar]

Attachment: E-Mail showing the described behaviour

Even better - you can do it yourself!

Go to http://trashmail.net/, create an e-mail address and you've got the testmail :-)

Anyway, attached is what you basically didn't need *g*

Comment 4

[Magnus Melin [:mkmelin]]

Yep I see this. The problem it that we incorrectly treat the Content-Transfer-Encoding as case senstive.

Content-Transfer-Encoding is case insensitive per http://tools.ietf.org/html/rfc2045#page-14

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Make it case insensitive.

Comment 6

[David :Bienvenu]

Comment on attachment 284768 [details] [diff] [review]
proposed fix

good one, thx, Magnus.

Comment 7

[Magnus Melin [:mkmelin]]

Thanks for the quick review:) Fix checked in.

Checking in mailnews/base/util/nsMsgDBFolder.cpp;
/cvsroot/mozilla/mailnews/base/util/nsMsgDBFolder.cpp,v  <--  nsMsgDBFolder.cpp
new revision: 1.325; previous revision: 1.324
done

Comment 8

[Alexander Skwar]

Wow, I'm very positively impressed - less than 1 week to get this fixed.

Thanks a lot for the work you put into it!