399344 - Remove the execute bit from a bunch of files in mozilla/camino

Status: RESOLVED FIXED

(mozilla.org :: CVS: Administration, task)

Description

[Mark Mentovai]

I'd like to get the execute bit removed from a bunch of files in mozilla/camino.  Most of these are image files that have no business being executable.  It looks silly and unprofessional to me that these end up being executable in our distributed package.

On most standard cvs servers, a server administrator needs to clear the execute bit on the appropriate ,v file.

Yes, I'm aware that the x-bit is unversioned and dropping it will affect all versions and branches in the repository.  I'm OK with that.  These are all image files or files that otherwise don't need to be executable.

This list was generated by doing "find mozilla/camino -type f -perm +100" in HEAD, MOZILLA_1_8_BRANCH, and CAMINO_1_5_BRANCH, concatenating the results, and running that through sort | uniq.  I verified that each item on the list doesn't need to be executable.  I removed mozilla/camino/confvars.sh from the list, although it doesn't NEED to be executable (configure sources it) because it's valid (if useless) as a standalone shell script, and all other projects have an executable confvars.sh.

Comment 1

[Mark Mentovai]

Attachment: Execute the execute bit on these files

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 284341 [details]
Execute the execute bit on these files

r=ardissone on the saneness and correctness of this list

Comment 3

[matthew zeier [:mrz]]

Ran a script that took your list and did a 'chmod a-x' on each versioned file.  A couple files from your list didn't exist.

chmod: cannot access `mozilla/camino/PreferencePanes/Personal/Personal.tiff,v': No such file or directory
chmod: cannot access `mozilla/camino/resources/images/chrome/SearchLeft.tiff,v': No such file or directory
chmod: cannot access `mozilla/camino/resources/images/chrome/SearchMiddle.tiff,v': No such file or directory
chmod: cannot access `mozilla/camino/resources/images/chrome/SearchPopUp.tiff,v': No such file or directory
chmod: cannot access `mozilla/camino/resources/images/chrome/SearchRight.tiff,v': No such file or directory
chmod: cannot access `mozilla/camino/resources/images/toolbar/addressbook_icon.tif,v': No such file or directory
chmod: cannot access `mozilla/camino/resources/images/toolbar/bookmarkmenu_icon.tif,v': No such file or directory
chmod: cannot access `mozilla/camino/resources/images/toolbar/bookmarktoolbar_icon.tif,v': No such file or directory
chmod: cannot access `mozilla/camino/resources/images/toolbar/brokenbookmark_icon.tif,v': No such file or directory
chmod: cannot access `mozilla/camino/resources/images/toolbar/rendezvous_icon.tif,v': No such file or directory
chmod: cannot access `mozilla/camino/resources/images/toolbar/searchWeb.tif,v': No such file or directory
chmod: cannot access `mozilla/camino/resources/images/toolbar/search_the_web.tif,v': No such file or directory
chmod: cannot access `mozilla/camino/resources/images/toolbar/top10_icon.tif,v': No such file or directory

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The ones that "don't exist" are only still live on the CAMINO_1_5_BRANCH, our current security branch; they've been obsoleted on the trunk and MOZILLA_1_8_BRANCH.

Comment 5

[Mark Mentovai]

Smokey's right.  Matthew, these files have already been removed on the trunk, but there's still got to be a ,v file for them elsewhere.  Could you remove the execute bit from the following files which do exist on CAMINO_1_5_BRANCH?:

mozilla/camino/PreferencePanes/Personal/Personal.tiff
mozilla/camino/resources/images/chrome/SearchLeft.tiff
mozilla/camino/resources/images/chrome/SearchMiddle.tiff
mozilla/camino/resources/images/chrome/SearchPopUp.tiff
mozilla/camino/resources/images/chrome/SearchRight.tiff
mozilla/camino/resources/images/toolbar/addressbook_icon.tif
mozilla/camino/resources/images/toolbar/bookmarkmenu_icon.tif
mozilla/camino/resources/images/toolbar/bookmarktoolbar_icon.tif
mozilla/camino/resources/images/toolbar/brokenbookmark_icon.tif
mozilla/camino/resources/images/toolbar/rendezvous_icon.tif
mozilla/camino/resources/images/toolbar/search_the_web.tif
mozilla/camino/resources/images/toolbar/searchWeb.tif
mozilla/camino/resources/images/toolbar/top10_icon.tif

Comment 6

[Dave Miller [:justdave]]

If they're not on the trunk, they'll be in the Attic directory at the same level in the tree.

Comment 7

[matthew zeier [:mrz]]

Dave - thanks for the pointer - a-x fixed.