Remove unused closure variable

RESOLVED FIXED

Status

()

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: longsonr, Assigned: longsonr)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 284364 [details] [diff] [review]
patch

closure is unused since the conversion to thebes. Might as well remove it completely.
Attachment #284364 - Flags: superreview?(tor)
Attachment #284364 - Flags: review?(tor)

Updated

11 years ago
Attachment #284364 - Flags: superreview?(tor)
Attachment #284364 - Flags: superreview+
Attachment #284364 - Flags: review?(tor)
Attachment #284364 - Flags: review+
(Assignee)

Updated

11 years ago
Attachment #284364 - Flags: approval1.9?
(Assignee)

Comment 1

11 years ago
Low risk removal of unused code.
Comment on attachment 284364 [details] [diff] [review]
patch

approved, but please, we'd prefer you not to spend time on things like this right now (unless they help prepare a patch for something which is a 1.9 blocker, perhaps).

Obviously it's up to you what you work on, but I'll have to stop approving pure cleanup at some point.
Attachment #284364 - Flags: approval1.9? → approval1.9+
Just a reminder to please commit this by Monday if you want to get it in before beta. Otherwise, approval1.9+ will be revoked, and you will need to re-request it after M9 if you still want to land the patch.
(Assignee)

Comment 4

11 years ago
In that case... checked in.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.