If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Work offline menu has incorrect state after cancelled request to go offline in sub windows

VERIFIED FIXED in Firefox 3 beta1

Status

()

Firefox
Menus
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

Trunk
Firefox 3 beta1
x86
Mac OS X
Points:
---
Bug Flags:
blocking-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
1. Start a longish download.
2. With the downloads window focused go to file and work offline.
3. In the cancel downloads prompt opt to stay online.

I know see that in the file menu the work offline option is ticked even though the browser is not working offline.

This is also a problem in the add-ons window.
(Assignee)

Updated

10 years ago
Flags: blocking-firefox3?
(Assignee)

Comment 1

10 years ago
Created attachment 284468 [details] [diff] [review]
patch rev 1

This also takes care of bug 399438.

Turning off autocheck from the offline menu means we only need to update the menu on window display and when offline changes. For background windows we must initialise and uninitialise the observer for this to happen properly
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #284468 - Flags: review?(gavin.sharp)
(Assignee)

Updated

10 years ago
Blocks: 399438
Flags: blocking-firefox3? → blocking-firefox3+
(Assignee)

Comment 2

10 years ago
Created attachment 284479 [details] [diff] [review]
patch rev 2

This removes the unnecessary parts. Properly initialising the BrowserOffline component fixes both issues.
Attachment #284468 - Attachment is obsolete: true
Attachment #284479 - Flags: review?(gavin.sharp)
Attachment #284468 - Flags: review?(gavin.sharp)
Attachment #284479 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 3

10 years ago
Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.868; previous revision: 1.867
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M9
verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3pre) Gecko/2007122704 Minefield/3.0b3pre and the steps to reproduce from comment #0

-> Verified fixed
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.