399528 - need "never for this site" option for the offline apps notificationbox

Status: VERIFIED FIXED

(Firefox :: General, defect, P2)

Description

[Dave Camp (:dcamp)]

We need to add some sort of "never for this site" option for the offline-apps notificationbox.

For this to work we need a convenient, reasonably discoverable way to recover from that decision.  I imagine it'll be pretty common to want to "wait and see" before deciding to use an app offline, without wanting that notificationbox every time you visit the site.

Comment 1

[Dave Camp (:dcamp)]

Attachment: v1

This patch adds a "Never for This Site" button to the offline notification bar, and some UI to manage the items that have been marked.

Comment 2

[Dave Camp (:dcamp)]

Attachment: notification bar

Comment 3

[Dave Camp (:dcamp)]

Attachment: prefs dlg

Comment 4

[Dave Camp (:dcamp)]

Attachment: exceptions dlg

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 302709 [details] [diff] [review]
v1

> offlineApps.available=This website (%S) is offering to store data on your computer for offline use.

nit: "This website (%S) is asking to store data on your computer for offline use."

>+<!ENTITY offlineNotify.label             "Prompt me when a website offers to install data for offline use">
>+<!ENTITY offlineNotify.accesskey         "P">

nit: "Tell me when a website asks to store data for offline use"

>+ <!ENTITY offlineAppsList.label           "The following websites have data installed for offline use:">

nit: "The following websites have stored data for offline use:"

>+offlinepermissionstext=You will not be prompted to save offline data for the following websites.

nit: "The following websites are not allowed to store data for offline use:"

One last suggestion would be to add a "Do Not Allow" or a "Not Now" (either string is fine) button. I know that's the same function as the (x) button, but we're finding that when offered two buttons, people look for a third.

Comment 6

[Dave Camp (:dcamp)]

Attachment: strings patch

Separating out string changes so they can land before the string freeze.

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 302709 [details] [diff] [review]
v1

this is ok for now, but I think the _manageCapability stuff is unnecessary and can be removed.

Comment 8

[Dave Camp (:dcamp)]

Checking in app/profile/firefox.js;
/cvsroot/mozilla/browser/app/profile/firefox.js,v  <--  firefox.js
new revision: 1.280; previous revision: 1.279
done
Checking in base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.971; previous revision: 1.970
done
Checking in components/preferences/advanced.js;
/cvsroot/mozilla/browser/components/preferences/advanced.js,v  <--  advanced.js
new revision: 1.31; previous revision: 1.30
done
Checking in components/preferences/advanced.xul;
/cvsroot/mozilla/browser/components/preferences/advanced.xul,v  <--  advanced.xul
new revision: 1.48; previous revision: 1.47
done
Checking in components/preferences/permissions.js;
/cvsroot/mozilla/browser/components/preferences/permissions.js,v  <--  permissions.js
new revision: 1.12; previous revision: 1.11
done
Checking in components/preferences/permissions.xul;
/cvsroot/mozilla/browser/components/preferences/permissions.xul,v  <--  permissions.xul
new revision: 1.8; previous revision: 1.7
done
Checking in locales/en-US/chrome/browser/browser.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/browser.properties,v  <--  browser.properties
new revision: 1.65; previous revision: 1.64
done
Checking in locales/en-US/chrome/browser/preferences/advanced.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/advanced.dtd,v  <--  advanced.dtd
new revision: 1.32; previous revision: 1.31
done
Checking in locales/en-US/chrome/browser/preferences/preferences.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/preferences.properties,v  <--  preferences.properties
new revision: 1.28; previous revision: 1.27
done

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 304900 [details]
strings patch

a=beltzner, but I think this is redundant now, yes?

Comment 10

[Dave Camp (:dcamp)]

Comment on attachment 304900 [details]
strings patch

Indeed.

Comment 11

[Dave Camp (:dcamp)]

Filed 418977 to make the exceptions dialog editable and remove the
manageCapability_ crap.

Comment 12

[pal-moz]

20080221_2259_firefox-3.0b4pre.en-US.win32.zip

click "Exceptions...", nothing happens (no dialog appears).

Comment 13

[pal-moz]

(In reply to comment #12)
> 20080221_2259_firefox-3.0b4pre.en-US.win32.zip
> 
> click "Exceptions...", nothing happens (no dialog appears).
> 

not always, but sometimes/often.

Comment 14

[pal-moz]

> (In reply to comment #12)
> > 20080221_2259_firefox-3.0b4pre.en-US.win32.zip
> > 
> > click "Exceptions...", nothing happens (no dialog appears).
> > 
> 
> not always, but sometimes/often.
> 

with Console 2,

Error: Ci is not defined
Source file: chrome://browser/content/preferences/advanced.js
Line: 162

Comment 15

[Marcia Knous [:marcia]]

Verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4pre) Gecko/2008022604 Minefield/3.0b4pre, Win XP and Linux. The issue that was referenced in Comment 14 is also fine, the Exceptions button works fine on XP.

Comment 16

[Dave Camp (:dcamp)]

409108 fixed the Exceptions button.

Comment 17

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=5193 has been added to Litmus.