Closed Bug 399528 Opened 14 years ago Closed 14 years ago

need "never for this site" option for the offline apps notificationbox


(Firefox :: General, defect, P2)




Firefox 3 beta2


(Reporter: dcamp, Assigned: dcamp)



(Keywords: late-l10n, uiwanted)


(4 files, 1 obsolete file)

We need to add some sort of "never for this site" option for the offline-apps notificationbox.

For this to work we need a convenient, reasonably discoverable way to recover from that decision.  I imagine it'll be pretty common to want to "wait and see" before deciding to use an app offline, without wanting that notificationbox every time you visit the site.
Flags: blocking-firefox3?
Flags: blocking-firefox3? → blocking-firefox3+
Keywords: uiwanted
Target Milestone: --- → Firefox 3 M10
Priority: -- → P2
Assignee: nobody → dcamp
Attached patch v1Splinter Review
This patch adds a "Never for This Site" button to the offline notification bar, and some UI to manage the items that have been marked.
Attachment #302709 - Flags: ui-review?(beltzner)
Attachment #302709 - Flags: review?(mconnor)
Attached image notification bar
Attached image prefs dlg
Attached image exceptions dlg
Keywords: late-l10n
Comment on attachment 302709 [details] [diff] [review]

> offlineApps.available=This website (%S) is offering to store data on your computer for offline use.

nit: "This website (%S) is asking to store data on your computer for offline use."

>+<!ENTITY offlineNotify.label             "Prompt me when a website offers to install data for offline use">
>+<!ENTITY offlineNotify.accesskey         "P">

nit: "Tell me when a website asks to store data for offline use"

>+ <!ENTITY offlineAppsList.label           "The following websites have data installed for offline use:">

nit: "The following websites have stored data for offline use:"

>+offlinepermissionstext=You will not be prompted to save offline data for the following websites.

nit: "The following websites are not allowed to store data for offline use:"

One last suggestion would be to add a "Do Not Allow" or a "Not Now" (either string is fine) button. I know that's the same function as the (x) button, but we're finding that when offered two buttons, people look for a third.
Attachment #302709 - Flags: ui-review?(beltzner) → ui-review+
Attached file strings patch (obsolete) —
Separating out string changes so they can land before the string freeze.
Attachment #304900 - Flags: approval1.9?
Comment on attachment 302709 [details] [diff] [review]

this is ok for now, but I think the _manageCapability stuff is unnecessary and can be removed.
Attachment #302709 - Flags: review?(mconnor) → review+
Checking in app/profile/firefox.js;
/cvsroot/mozilla/browser/app/profile/firefox.js,v  <--  firefox.js
new revision: 1.280; previous revision: 1.279
Checking in base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.971; previous revision: 1.970
Checking in components/preferences/advanced.js;
/cvsroot/mozilla/browser/components/preferences/advanced.js,v  <--  advanced.js
new revision: 1.31; previous revision: 1.30
Checking in components/preferences/advanced.xul;
/cvsroot/mozilla/browser/components/preferences/advanced.xul,v  <--  advanced.xul
new revision: 1.48; previous revision: 1.47
Checking in components/preferences/permissions.js;
/cvsroot/mozilla/browser/components/preferences/permissions.js,v  <--  permissions.js
new revision: 1.12; previous revision: 1.11
Checking in components/preferences/permissions.xul;
/cvsroot/mozilla/browser/components/preferences/permissions.xul,v  <--  permissions.xul
new revision: 1.8; previous revision: 1.7
Checking in locales/en-US/chrome/browser/;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/,v  <--
new revision: 1.65; previous revision: 1.64
Checking in locales/en-US/chrome/browser/preferences/advanced.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/advanced.dtd,v  <--  advanced.dtd
new revision: 1.32; previous revision: 1.31
Checking in locales/en-US/chrome/browser/preferences/;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/,v  <--
new revision: 1.28; previous revision: 1.27
Closed: 14 years ago
Resolution: --- → FIXED
Comment on attachment 304900 [details]
strings patch

a=beltzner, but I think this is redundant now, yes?
Attachment #304900 - Flags: approval1.9? → approval1.9+
Comment on attachment 304900 [details]
strings patch

Attachment #304900 - Attachment is obsolete: true
Attachment #304900 - Flags: approval1.9+
Filed 418977 to make the exceptions dialog editable and remove the
manageCapability_ crap.

click "Exceptions...", nothing happens (no dialog appears).
(In reply to comment #12)
> click "Exceptions...", nothing happens (no dialog appears).

not always, but sometimes/often.
> (In reply to comment #12)
> >
> > 
> > click "Exceptions...", nothing happens (no dialog appears).
> > 
> not always, but sometimes/often.

with Console 2,

Error: Ci is not defined
Source file: chrome://browser/content/preferences/advanced.js
Line: 162
Depends on: 419108
Flags: in-litmus?
Verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4pre) Gecko/2008022604 Minefield/3.0b4pre, Win XP and Linux. The issue that was referenced in Comment 14 is also fine, the Exceptions button works fine on XP.
409108 fixed the Exceptions button.
Depends on: 420396 has been added to Litmus.
Flags: in-litmus? → in-litmus+
You need to log in before you can comment on or make changes to this bug.