399707 - Add inverse matching for string flags

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Dave Townsend [:mossop]]

For the string flags (application and the coming os flag) we can currently only apply a manifest directive on a match, not on a mismatch.

As an example I have an extension where I want to have one skin on mac and another on all other operating systems. It's not totally impossible to do it now but it would be far simpler to be able to have:

skin foo classic/1.0 skin/mac os=darwin
skin foo classic/1.0 skin/default os!=darwin

I can also imagine situations where people want to do one thing for one app and another everywhere else which this would fix as well.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Implements a != comparison for string flags.

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 284788 [details] [diff] [review]
patch rev 1

Looking for approval, this is a simple change with unit testing that adds a useful feature for app/extension authors.

Comment 3

[Damon Sicore (:damons)]

Comment on attachment 284788 [details] [diff] [review]
patch rev 1

a=release drivers

Comment 4

[Reed Loden [:reed]]

Checking in chrome/src/nsChromeRegistry.cpp;
/cvsroot/mozilla/chrome/src/nsChromeRegistry.cpp,v  <--  nsChromeRegistry.cpp
new revision: 1.356; previous revision: 1.355
done
RCS file: /cvsroot/mozilla/chrome/test/unit/test_bug399707.js,v
done
Checking in chrome/test/unit/test_bug399707.js;
/cvsroot/mozilla/chrome/test/unit/test_bug399707.js,v  <--  test_bug399707.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/chrome/test/unit/data/test_bug399707.manifest,v
done
Checking in chrome/test/unit/data/test_bug399707.manifest;
/cvsroot/mozilla/chrome/test/unit/data/test_bug399707.manifest,v  <--  test_bug399707.manifest
initial revision: 1.1
done