Closed
Bug 399741
Opened 17 years ago
Closed 11 years ago
SEC_Init is dead code
Categories
(NSS :: Libraries, defect)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 545273
3.12.6
People
(Reporter: wtc, Assigned: wtc)
References
()
Details
Attachments
(1 file)
1.47 KB,
patch
|
wtc
:
review-
|
Details | Diff | Splinter Review |
The function SEC_Init, defined in lib/util/secinit.c, is dead code. http://lxr.mozilla.org/security/search?string=SEC_Init
Comment 1•12 years ago
|
||
Since it isn't there anymore. lines http://dxr.mozilla.org/mozilla-central/security/nss/tests/pkcs11/netscape/suites/security/pkcs11/pk11test.c.html#l31 and 288 can be removed I think
Comment 2•12 years ago
|
||
Comment 3•11 years ago
|
||
Comment on attachment 695171 [details] [diff] [review] Patch that removes SEC_Init - dead code This patch still applies cleanly on m-c it seems...
Attachment #695171 -
Flags: review?(wtc)
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 695171 [details] [diff] [review] Patch that removes SEC_Init - dead code Thank you for the patch. The security/nss/tests/pkcs11 directory is the old PKCS #11 test suite. We have trouble open-sourcing the two or three programs needed by the test suite, so the test suite is now obsolete. We should remove the security/nss/tests/pkcs11 directory.
Attachment #695171 -
Flags: review?(wtc) → review-
Assignee | ||
Comment 5•11 years ago
|
||
I forgot about this bug report and rediscovered this problem in 2010. I removed SEC_Init in bug 545273.
Assignee: nobody → wtc
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Target Milestone: --- → 3.12.6
You need to log in
before you can comment on or make changes to this bug.
Description
•