399746 - Exception... "'[JavaScript Error: "gImageView.data[i] has no properties" {file: "chrome://browser/content/pageinfo/pageInfo.js" line: 554}]' when calling method: [nsIDOMNodeFilter::acceptNode]"

Status: RESOLVED FIXED

(Firefox :: Page Info Window, defect)

Description

[Reed Loden [:reed]]

Got this exception when I opened the Page Info window today:

Error: uncaught exception: [Exception... "'[JavaScript Error: "gImageView.data[i] has no properties" {file: "chrome://browser/content/pageinfo/pageInfo.js" line: 554}]' when calling method: [nsIDOMNodeFilter::acceptNode]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://browser/content/pageinfo/pageInfo.js :: doGrab :: line 499"  data: yes]

Comment 1

[Florian Quèze [:florian]]

Do you have some steps to reproduce? The url of the page?

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

I can't easily reproduce: Reed, can you provide more details on how to see this exception?

Comment 3

[Reed Loden [:reed]]

I came across this again today. Here's my STR:

1. Visit http://news.bbc.co.uk/2/hi/asia-pacific/7132886.stm
2. Open Page Info dialog
3. See error in error console

Florian, how's that?

Comment 4

[Reed Loden [:reed]]

Oh, the error has changed a bit now.

Error: uncaught exception: [Exception... "'[JavaScript Error: "gImageView.data[i] is undefined" {file: "chrome://browser/content/pageinfo/pageInfo.js" line: 556}]' when calling method: [nsIDOMNodeFilter::acceptNode]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://browser/content/pageinfo/pageInfo.js :: doGrab :: line 501"  data: yes]

Comment 5

[Daniel Brooks [:db48x]]

mmm, that's an interesting error.

Comment 6

[Florian Quèze [:florian]]

Apparently we get screwed because |"watch" in { }| returns true.

Comment 7

[Florian Quèze [:florian]]

Attachment: patch v1

Comment 8

[Florian Quèze [:florian]]

This is a regression from bug 201264.

Comment 9

[Daniel Brooks [:db48x]]

Comment on attachment 292698 [details] [diff] [review]
patch v1

r=db48x

Comment 10

[Asaf Romano (gone)]

Comment on attachment 292698 [details] [diff] [review]
patch v1

r=mano

Comment 11

[Reed Loden [:reed]]

Comment on attachment 292698 [details] [diff] [review]
patch v1

Fixes a JS exception due to use of JS-reserved word.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 292698 [details] [diff] [review]
patch v1

a=beltzner

Comment 13

[Florian Quèze [:florian]]

Fixed for both Firefox and SeaMonkey.

Checking in browser/base/content/pageinfo/pageInfo.js;
/cvsroot/mozilla/browser/base/content/pageinfo/pageInfo.js,v  <--  pageInfo.js
new revision: 1.11; previous revision: 1.10
done
Checking in suite/browser/pageinfo/pageInfo.js;
/cvsroot/mozilla/suite/browser/pageinfo/pageInfo.js,v  <--  pageInfo.js
new revision: 1.4; previous revision: 1.3
done