399753 - Remove "nsISupportsArray" in the layout directory

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jonathan Steele]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007101214 Minefield/3.0a9pre
Build Identifier: 

"nsISupportsArray" should be gone in the tree. 

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Jonathan Steele]

Attachment: Clean up v1 (DOES NOT COMPILE)

Comment 2

[Boris Zbarsky [:bzbarsky]]

Please ask someone else for review.  I won't have time to get to this in any sort of reasonable timeframe.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 284806 [details] [diff] [review]
Clean up v1 (DOES NOT COMPILE)

r+sr+a1.9=dbaron

Comment 4

[Reed Loden [:reed]]

Checking in layout/xul/base/src/nsSplitterFrame.h;
/cvsroot/mozilla/layout/xul/base/src/nsSplitterFrame.h,v  <--  nsSplitterFrame.h
new revision: 1.46; previous revision: 1.45
done
Checking in layout/xul/base/src/nsScrollbarFrame.h;
/cvsroot/mozilla/layout/xul/base/src/nsScrollbarFrame.h,v  <--  nsScrollbarFrame.h
new revision: 1.36; previous revision: 1.35
done
Checking in layout/xul/base/src/nsSliderFrame.h;
/cvsroot/mozilla/layout/xul/base/src/nsSliderFrame.h,v  <--  nsSliderFrame.h
new revision: 1.70; previous revision: 1.69
done
Checking in layout/xul/base/src/nsListBoxBodyFrame.cpp;
/cvsroot/mozilla/layout/xul/base/src/nsListBoxBodyFrame.cpp,v  <--  nsListBoxBodyFrame.cpp
new revision: 1.96; previous revision: 1.95
done
Checking in layout/xul/base/src/nsMenuFrame.h;
/cvsroot/mozilla/layout/xul/base/src/nsMenuFrame.h,v  <--  nsMenuFrame.h
new revision: 1.129; previous revision: 1.128
done
Checking in layout/xul/base/src/nsSplitterFrame.cpp;
/cvsroot/mozilla/layout/xul/base/src/nsSplitterFrame.cpp,v  <--  nsSplitterFrame.cpp
new revision: 1.174; previous revision: 1.173
done
Checking in layout/xul/base/src/nsMenuBarListener.cpp;
/cvsroot/mozilla/layout/xul/base/src/nsMenuBarListener.cpp,v  <--  nsMenuBarListener.cpp
new revision: 1.85; previous revision: 1.84
done
Checking in layout/base/nsIPresShell.h;
/cvsroot/mozilla/layout/base/nsIPresShell.h,v  <--  nsIPresShell.h
new revision: 3.215; previous revision: 3.214
done
Checking in layout/base/nsCSSFrameConstructor.cpp;
/cvsroot/mozilla/layout/base/nsCSSFrameConstructor.cpp,v  <--  nsCSSFrameConstructor.cpp
new revision: 1.1415; previous revision: 1.1414
done
Checking in layout/inspector/src/inDOMUtils.h;
/cvsroot/mozilla/layout/inspector/src/inDOMUtils.h,v  <--  inDOMUtils.h
new revision: 1.11; previous revision: 1.10
done
Checking in layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp;
/cvsroot/mozilla/layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp,v  <--  nsTreeBodyFrame.cpp
new revision: 1.333; previous revision: 1.332
done

Comment 5

[Reed Loden [:reed]]

This caused bustage in nsTreeBodyFrame.cpp due to nsTreeStyleCache.h/nsTreeStyleCache.cpp using nsISupportsArray still. Backed out that portion of the patch.

Comment 6

[Reed Loden [:reed]]

I completely backed this out due to the massive bustage this caused. A new patch needs to be submitted and reviewed, as this patch was untested and would have easily failed if it had been actually compiled. Please do not submit patches that touch things like this without compiling them first.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Note that I did ask Jonathan whether he'd made sure that nsISupportsArray was unused... and he said he had.

Comment 8

[Damon Sicore (:damons)]

Comment on attachment 284806 [details] [diff] [review]
Clean up v1 (DOES NOT COMPILE)

Resetting all approval1.9+ flags on bugs that have not been checked in by Oct 22 11:59 PM PDT.  Please re-request approval if needed.

Comment 9

[Arpad Borsos [:Swatinem]]

Attachment: patch

The only real change was to in(I)DOMUtils. DOM Inspector needs to be patched for those changed. That must be done later anyway since comm-central&dom-inspector are tracking 1.9.1.

layout/html/tests/TestAttributes.cpp includes some nsISupportsArray but that file is dead anyway and should be removed in another bug.

The rest is nsITreeView stuff handled in the other bug.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't think we should change inIDOMUtils --- Firebug and who knows what else would break for sure. Let's get rid of what we can easily get rid of now, and then deal with all the public-interface stuff separately.

Comment 11

[Arpad Borsos [:Swatinem]]

Attachment: patch, v2 [pushed: comment 12]

Without those interface changes it is just basic includes/forward decl/comment cleanup.

Comment 12

[Arpad Borsos [:Swatinem]]

Comment on attachment 370017 [details] [diff] [review]
patch, v2 [pushed: comment 12]

http://hg.mozilla.org/mozilla-central/rev/fdac16a5cff2

Comment 13

[Arpad Borsos [:Swatinem]]

Closing this. Any inIDOMUtils cleanup should be a new bug.