399784 - Settings... button in Security pref pane is stretched vertically

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Michael Monreal [:micmon]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3) Gecko/20061201 Firefox/2.0.0.3 (Ubuntu-feisty)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a9pre) Gecko/2007101404 Minefield/3.0a9pre

There is one button in the preferences window that has a bigger size than the rest. "Settings..." in the security category. It should have the same size as other buttons

Reproducible: Always

Comment 1

[Michael Monreal [:micmon]]

Attachment: Screenshot

Comment 2

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007101410 Minefield/3.0a9pre
No such problem on Windows.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of Vista

Actually, this is bigger on Vista, too, using the "Firefox (default) 2.0" theme.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Confirming; this is likely due to the way its implemented within a <groupbox>?

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Confirming; this is likely due to the way its implemented within a <groupbox>?

Comment 6

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Yeah, nothing to do with platform, and everything to do with font size and resolution, and whether that makes the description wrap to a second line (well, except on Mac, where by default it doesn't wrap, but the button's still weirded out, placed too low instead of being too tall). XUL doesn't actually offer a good alignment for a button next to text that might be one line, or might be two, but align="center" comes pretty close, looking good with one line and not looking wrong with two lines.

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 285043 [details] [diff] [review]
Fix v.1

a=mconnor on behalf of drivers

Comment 9

[Phil Ringnalda (:philor)]

browser/components/preferences/security.xul 1.21

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008011005 Minefield/3.0b3pre, Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008011005 Minefield/3.0b3pre

and

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008011004 Minefield/3.0b3pre (Ubuntu 7.04).