399802 - don't migrate RSS accounts until we have a RSS reader

Status: RESOLVED WONTFIX

(SeaMonkey :: Startup & Profiles, defect)

Description

[Karsten Düsterloh]

When importing a Thunderbird profile which has an RSS account configured, we import that as is. Of course, it doesn't work (and its properties panel even results in a XUL error because it's not there)...

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix

This fixes the problem. If we don't know the type of server, then we skip that server (and any copying) and then we strip out the prefs at the end of the function so that they don't get written into the new prefs.js file.

Comment 2

[[e-mail]]

Sorry, but I don't see how this works.
* Where do you remove the rss server from the list of servers pref?
* Where do you remove the account for the rss server?
* Where do you remove the identity for the rss account?

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> Sorry, but I don't see how this works.
> * Where do you remove the rss server from the list of servers pref?

Where's this pref? I couldn't find it on my current build.

> * Where do you remove the account for the rss server?
> * Where do you remove the identity for the rss account?

ok, I missed these. They will probably require a bit more rework.

Comment 4

[Justin Wood (:Callek)]

I mentioned this on IRC, but can't recall if I caught you Mark.

But is there any chance in storing at least RSS feed data in a "hidden" prefBranch so that when the RSS stuff (that I am hoping to finish) is done we won't need to re-do a migration to make it all work, I can just pull from those hidden prefs with something like,

"SeaMonkey has discovered old RSS accounts from the profile migration, would you like to import them now?"  clicking yes/ok would of course move them straight into the normal account view using whatever code I come up with.  No, would just delete that pref branch.

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #4)
> But is there any chance in storing at least RSS feed data in a "hidden"
> prefBranch so that when the RSS stuff (that I am hoping to finish) is done we
> won't need to re-do a migration to make it all work, I can just pull from those
> hidden prefs with something like,
> "SeaMonkey has discovered old RSS accounts from the profile migration, would
> you like to import them now?"  clicking yes/ok would of course move them
> straight into the normal account view using whatever code I come up with.  No,
> would just delete that pref branch.

It is a possibility. The other option could be to have a menu option "Import RSS accounts" that would be capable of importing from Thunderbird profiles (see Import Bookmarks in the bookmarks mananger, current trunk, for an example, except that only does existing SeaMonkey bookmarks at the moment).

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 284876 [details] [diff] [review]
The fix

This needs more rework than what we've got here.

Comment 7

[Serge Gautherie (:sgautherie)]

Mark,
Are you still working on this ?

Comment 8

[Mark Banner (:standard8)]

(In reply to comment #7)
> Mark,
> Are you still working on this ?
> 
Err, not at the moment.

Comment 9

[Justin Wood (:Callek)]

We now have a mailnews feed reader... WONFTIX